Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add merge queue #26871

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: add merge queue #26871

wants to merge 3 commits into from

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Sep 3, 2024

Description

Open in GitHub Codespaces

This PR introduces workflow support for merge queues, adding the "merge_group" trigger to the relevant GitHub actions

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3012

Manual testing steps

  1. CI works with merge queues

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr requested a review from a team as a code owner September 3, 2024 19:04
Copy link
Contributor

github-actions bot commented Sep 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [7f5d155]
Page Load Metrics (1987 ± 163 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint149227031998338162
domContentLoaded145426931959336161
load149327081987339163
domInteractive13202464019
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (ce04ae8) to head (7f5d155).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26871   +/-   ##
========================================
  Coverage    70.14%   70.14%           
========================================
  Files         1424     1424           
  Lines        49572    49572           
  Branches     13868    13868           
========================================
  Hits         34769    34769           
  Misses       14803    14803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsyoboieltr itsyoboieltr self-assigned this Sep 4, 2024
Copy link

sonarcloud bot commented Sep 20, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [4cd4e36]
Page Load Metrics (1690 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19722961561491236
domContentLoaded144722751662212102
load146322871690218105
domInteractive13145432914
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants