Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update scam token warning #26994

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

fix: Update scam token warning #26994

wants to merge 25 commits into from
+135 −40

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Sep 9, 2024 •
edited
Loading

Description

This PR updates the scam warning to be less aggressive and to also include a suggested ticker symbol.

I also took the opportunity to remove the redundant MATIC chain collision check, which is no longer needed since the remote chain list has been updated upstream.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-384

Manual testing steps

Add a custom network, with a custom/incorrect ticker (try adding Polygon with MATIC ticker)

Scam warning on token list page should reflect new copy from ticket.

Screenshots/Recordings

Screenshot 2024-09-09 at 11 17 17 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title Fix/mmassets 384 update scam token warning fix: Update scam token warning Sep 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gambinish gambinish marked this pull request as ready for review September 10, 2024 00:52
@gambinish gambinish requested review from a team as code owners September 10, 2024 00:52
@metamaskbot
Copy link
Collaborator

Builds ready [17e18a8]
Page Load Metrics (2010 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17282453200120297
domContentLoaded17072435196418488
load17302439201019091
domInteractive22152583417
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 514 Bytes (0.01%)
  • common: 248 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [cd931f8]
Page Load Metrics (1778 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148826251781274131
domContentLoaded147625411758265127
load148525531778265127
domInteractive147940168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 514 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5788ae8]
Page Load Metrics (2103 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17662392211217885
domContentLoaded17552370207017785
load17782384210316881
domInteractive247948189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 614 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@gambinish
Add test coverage
70f82e6
@gambinish
Merge branch 'fix/mmassets-384_update-scam-token-warning' of github.c…
0e886d0 
…om:MetaMask/metamask-extension into fix/mmassets-384_update-scam-token-warning
@metamaskbot
Copy link
Collaborator

Builds ready [0e886d0]
Page Load Metrics (1745 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31121961657346166
domContentLoaded14932018169913163
load15012249174517282
domInteractive17209494120
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 614 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [e43b0fc]
Page Load Metrics (1810 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint159328291822254122
domContentLoaded157927991788249120
load158328041810246118
domInteractive26203543718
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 614 Bytes (0.01%)
  • common: 241 Bytes (0.00%)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimtb salimtb Awaiting requested review from salimtb

@legobeat legobeat Awaiting requested review from legobeat

@alfeng6 alfeng6 Awaiting requested review from alfeng6

@darkwing darkwing Awaiting requested review from darkwing

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gambinish @metamaskbot @darkwing @alfeng6 @salimtb @legobeat