Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename SECURITY_PROVIDER_SUPPORTED_CHAIN_IDS_FALLBACK_LIST #28337

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Nov 7, 2024

Description

Rename SECURITY_PROVIDER_SUPPORTED_CHAIN_IDSSECURITY_PROVIDER_SUPPORTED_CHAIN_IDS_FALLBACK_LIST to be more explicit now that we are fetching the chain ids list from the Security Provider API introduced in #25716

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2846
Related: #25716

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand added the team-confirmations Push issues to confirmations team label Nov 7, 2024
@digiwand digiwand requested review from a team as code owners November 7, 2024 06:55
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0ac7f2c]
Page Load Metrics (1991 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint173928121986261126
domContentLoaded172827631950257123
load174128081991266128
domInteractive17188553718
backgroundConnect106935209
firstReactRender533011154823
getState482202211
initialActions01000
loadScripts125322471469236113
setupStore1188252210
uiStartup195230792236316152
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 14 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 28 Bytes (0.00%)

@digiwand digiwand added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit bde47a6 Nov 7, 2024
82 checks passed
@digiwand digiwand deleted the refactor-rename-blockaid-supported-chain-id-var branch November 7, 2024 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants