fix: Phishing page metrics

[mindofmar]

Description

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/103/views/1?pane=issue&itemId=86413189

Manual testing steps

See Issue attached in Related Issues.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[mindofmar]

I have read the CLA Document and I hereby sign the CLA

[metamaskbot]

Builds ready [e634bfc]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2184 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	255	2614	2103	462	222
		domContentLoaded	1891	2532	2152	176	84
		load	1950	2540	2184	177	85
		domInteractive	30	110	53	20	10
		backgroundConnect	10	76	36	21	10
		firstReactRender	56	300	145	57	28
		getState	8	60	23	19	9
		initialActions	0	0	0	0	0
		loadScripts	1357	1927	1602	141	68
		setupStore	6	58	14	14	7
		uiStartup	2161	2880	2466	215	103

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 90 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[cryptotavares]

So there's a couple of things here:

1. We should try to avoid having inline strings spread out, as it will make it much harder to update the blockReason value in the future (we would need to update the controller, and then remember to search for the actual string value in the Extension codebase). Here we could use the type from the PhishingController (if it is not exported, we can export it).
2. we already have an if block above where we set a specific blockReason. And here we are adding another if clause for the blockReason to set the blockedUrl. We should collapse into the pre-existing if block that sets the blockReason and set the blockUrl as well.

Suggestion, update the above if block as below:

      let blockReason;
      let blockedUrl = hostname;
      if (phishingTestResponse?.result && blockedRequestResponse.result) {
        blockReason = `${phishingTestResponse.type} and ${blockedRequestResponse.type}`;
      } else if (phishingTestResponse?.result) {
        blockReason = phishingTestResponse.type;
      } else {
        blockReason = blockedRequestResponse.type;
        blockedUrl = details.initiator;
      }

Let me know your thoughts?