Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Bug]: When the network is changed by selecting an RPC URL from the dropdown menu, the view is automatically switches from the "Current" to the "Popular" network view #29957

Closed
sleepytanya opened this issue Jan 29, 2025 · 4 comments
Labels
regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jan 29, 2025

Describe the bug

When a network change is initiated through the selection of an RPC URL from the dropdown menu, the interface transitions from the "Current" network view to the "Popular" network view.
In this scenario, while the Network picker updates to display the icon of the newly selected network, the token list remains reflective of the previously selected network (while the Popular view implies that tokens from all added networks will be displayed)

Expected behavior

Selected user view preferences are respected

Screenshots/Recordings

Screen.Recording.2025-01-28.at.22.37.52.mov
Image

Steps to reproduce

  1. Select Current network view
  2. Switch to another network by clicking on RPC URL in the dropdown menu

Error messages or log output

Detection stage

In production (default)

Version

12.10.1

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 sev-2 team-wallet-ux type-bug labels Jan 29, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 29, 2025
@sleepytanya sleepytanya changed the title [Bug]: [Bug]: When the network is changed by selecting an RPC URL from the dropdown menu, the view is automatically switches from the "Popular" to the "Current" network view [Bug]: [Bug]: When the network is changed by selecting an RPC URL from the dropdown menu, the view is automatically switches from the "Current" to the "Popular" network view Jan 29, 2025
@jvbriones jvbriones added Sev2-normal Normal severity; minor loss of service or inconvenience. and removed sev-2 labels Jan 29, 2025
@danjm
Copy link
Contributor

danjm commented Jan 29, 2025

Is this the same as #29814?

@hesterbruikman
Copy link

Issue seems fixed via #29943

@sleepytanya could you confirm with a build from that PR please?

@sleepytanya
Copy link
Contributor Author

sleepytanya commented Jan 31, 2025

@danjm I think you are right. they do look like the same issue. I'll close another issue in favor of this one.

@sleepytanya
Copy link
Contributor Author

@hesterbruikman

Fixed, closing:

switch_rpc.mov

@danjm Re-opening the #29814 as that issue is not fixed by #29943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets type-bug
Projects
Archived in project
Development

No branches or pull requests

5 participants
@jvbriones @danjm @hesterbruikman @sleepytanya and others