Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lint en_GB locale #29967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Lint en_GB locale #29967

wants to merge 1 commit into from
+912 −518

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 29, 2025 •
edited by github-actions bot
Loading

Description

The verify-locales linter script now lints en_GB. Previously it was ignored, so it had accumulated errors. All errors in this locale file have been corrected as well.

This locale file is not actually used in the app, it's just present to enable us to set a different UK-specific store description.

Open in GitHub Codespaces

Related issues

Fixes #29965

Manual testing steps

  1. Add a new message to en_GB
  2. Call yarn verify-locales, and see that it highlights the error and fails
  3. Call yarn verify-locales --fix, and see that it fixes the error and fails
  4. Call yarn verify-locales again to verify it now passes

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt force-pushed the lint-en_GB-locale branch 2 times, most recently from 45a0fe9 to b075c0b Compare January 29, 2025 15:05
@Gudahtt Gudahtt marked this pull request as ready for review January 29, 2025 15:57
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 29, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [fdec48e]
Page Load Metrics (2401 ± 227 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45930871844788378
domContentLoaded180232222376465223
load181632822401472227
domInteractive28259847034
backgroundConnect9110422713
firstReactRender2178442411
getState55927189
initialActions01000
loadScripts129924511797394189
setupStore1064262010
uiStartup209036302725509244
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt
fix: Lint en_GB locale
ece8142 
The `verify-locales` linter script now lints `en_GB`. Previously it was
ignored, so it had accumulated errors. All errors in this locale file
have been corrected as well.

This locale file is not actually used in the app, it's just present to
enable us to set a different UK-specific store description.

Closes #29965
@Gudahtt Gudahtt enabled auto-merge January 29, 2025 22:08
@metamaskbot
Copy link
Collaborator

Builds ready [ece8142]
Page Load Metrics (1644 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37619931566299144
domContentLoaded14391929160612560
load14522067164414067
domInteractive25111362110
backgroundConnect879372210
firstReactRender1596382914
getState489212512
initialActions01000
loadScripts1039142411679847
setupStore74713115
uiStartup169427701927259124
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-extension-platform team-wallet-framework
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: en_GB locale not covered by linter
3 participants
@Gudahtt @metamaskbot @pedronfigueiredo