Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong function name in "077-supplement-for-088.ts" #29907

Open
Teng-Web3 opened this issue Jan 25, 2025 · 5 comments · May be fixed by #29971
Open

[Bug]: Wrong function name in "077-supplement-for-088.ts" #29907

Teng-Web3 opened this issue Jan 25, 2025 · 5 comments · May be fixed by #29971
Labels
external-contributor regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 Sev3-low Low severity; minimal to no impact upon users team-extension-platform type-bug

Comments

@Teng-Web3
Copy link

Describe the bug

I'm reading the metamask source code recently and found a bug:
The function name is currently named "transformState077For086" in "077-supplement-for-088.ts"
export default function transformState077For086
It called in file "077.js"
import transformState077For088 from './077-supplements/077-supplement-for-088'; newState = transformState077For088(newState);
Although this does not affect normal calls, because the imported function name and the default exported function name can be inconsistent.
But this is still a issue that should be fixed because:
1.Incorrect function names affect code readability
2.Wrong function names will be displayed during debugging
3.It violates the principle of code consistency

Expected behavior

Rename named "transformState077For086" to "transformState077For088" in "077-supplement-for-088.ts"

Screenshots/Recordings

No response

Steps to reproduce

No need.

Error messages or log output

Detection stage

In production (default)

Version

12.10.1

Build type

None

Browser

Chrome

Operating system

Windows

Hardware wallet

No response

Additional context

No response

Severity

No response

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 25, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 25, 2025
@metamaskbot metamaskbot added external-contributor regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 labels Jan 25, 2025
@Teng-Web3
Copy link
Author

Please assign it to me if it need to fix

@Teng-Web3 Teng-Web3 changed the title [Bug]: [Bug]: Wrong function name in "077-supplement-for-088.ts" Jan 26, 2025
@DanielTech21 DanielTech21 added team-extension-platform Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Jan 27, 2025
@DanielTech21
Copy link

Hi @Teng-Web3

Thanks for bringing this to our attention.

Our team will review it and get back to you.

@gauthierpetetin gauthierpetetin added Sev2-normal Normal severity; minor loss of service or inconvenience. Sev3-low Low severity; minimal to no impact upon users and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. Sev2-normal Normal severity; minor loss of service or inconvenience. labels Jan 28, 2025
@gauthierpetetin
Copy link
Contributor

Hi @Teng-Web3 , feel free to open a PR to fix this issue if you want to. Thanks

@Teng-Web3
Copy link
Author

@gauthierpetetin Sure, I will fix it, thanks!

@gauthierpetetin
Copy link
Contributor

Thanks a lot @Teng-Web3

@Teng-Web3 Teng-Web3 linked a pull request Jan 29, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 Sev3-low Low severity; minimal to no impact upon users team-extension-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

4 participants