Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MetaMask links not working from within Snaps UI #29978

Open
9 tasks
hmalik88 opened this issue Jan 29, 2025 · 0 comments
Open
9 tasks

Fix MetaMask links not working from within Snaps UI #29978

hmalik88 opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
team-snaps-platform Snaps Platform team

Comments

@hmalik88
Copy link
Contributor

What is this about?

Currently, MetaMask link functionality only works inside of Snaps UI content that is inside of an expanded notification. The logic doesn't account for clicks of links inside of Snap dialogs. Clicking the link keeps you in the popup, because navigating to say the home page means that the home page component kicks you back to the pending approval (dialog). We need to add logic that will cancel the dialog if a user clicks the link and possibly emit an event letting the snap dev know that the dialog was cancelled because of a link visit.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@hmalik88 hmalik88 added the team-snaps-platform Snaps Platform team label Jan 29, 2025
@hmalik88 hmalik88 self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

No branches or pull requests

1 participant