You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, MetaMask link functionality only works inside of Snaps UI content that is inside of an expanded notification. The logic doesn't account for clicks of links inside of Snap dialogs. Clicking the link keeps you in the popup, because navigating to say the home page means that the home page component kicks you back to the pending approval (dialog). We need to add logic that will cancel the dialog if a user clicks the link and possibly emit an event letting the snap dev know that the dialog was cancelled because of a link visit.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
Engineering (needed in most cases)
Design
Product
QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
Security
Legal
Marketing
Management (please specify)
Other (please specify)
References
No response
The text was updated successfully, but these errors were encountered:
What is this about?
Currently, MetaMask link functionality only works inside of Snaps UI content that is inside of an expanded notification. The logic doesn't account for clicks of links inside of Snap dialogs. Clicking the link keeps you in the popup, because navigating to say the home page means that the home page component kicks you back to the pending approval (dialog). We need to add logic that will cancel the dialog if a user clicks the link and possibly emit an event letting the snap dev know that the dialog was cancelled because of a link visit.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: