Migrate the bip 32 and bip 44 to POM #30179
Comments
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 13, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** PR to migrate snap-bip32 test scenario to POM PR to migrate snap-bip44 test scenario to POM <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30175?quickstart=1) ## **Related issues** Fixes: #29894 #30179 ## **Manual testing steps** yarn build:test:flask yarn test:e2e:single test/e2e/snaps/test-snap-bip-32.spec.ts --browser=chrome --leave-running yarn test:e2e:single test/e2e/snaps/test-snap-bip-44.spec.ts --browser=chrome --leave-running ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
PatrykLucka
pushed a commit
that referenced
this issue
Feb 19, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/30175?quickstart=1){kind=link}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** PR to migrate snap-bip32 test scenario to POM PR to migrate snap-bip44 test scenario to POM <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30175?quickstart=1) ## **Related issues** Fixes: #29894 #30179 ## **Manual testing steps** yarn build:test:flask yarn test:e2e:single test/e2e/snaps/test-snap-bip-32.spec.ts --browser=chrome --leave-running yarn test:e2e:single test/e2e/snaps/test-snap-bip-44.spec.ts --browser=chrome --leave-running ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Complete in the PR #30175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
This issue is to the track the effort required to migrate bip-32 and bip-44 test scenario to POM
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: