Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate locales_only to github actions #30787

Open
1 of 9 tasks
desi opened this issue Mar 5, 2025 · 0 comments · May be fixed by #30898
Open
1 of 9 tasks

Migrate locales_only to github actions #30787

desi opened this issue Mar 5, 2025 · 0 comments · May be fixed by #30898
Assignees
Labels
team-dev-ops DevOps team team-extension-platform Extension Platform team

Comments

@desi
Copy link
Contributor

desi commented Mar 5, 2025

What is this about?

Currently we are encountering an issue on trying to merge translations due to test-lint having been moved to github-actions and locales_only in CI doesn't know about github-actions.

See:

CircleCI error: https://app.circleci.com/pipelines/gh/MetaMask/metamask-extension/128768

Scenario

n/a

Design

n/a

Technical Details

n/a

Threat Modeling Framework

n/a

Acceptance Criteria

Can merge crowdin translation PRs without issue.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@desi desi added team-extension-platform Extension Platform team team-dev-ops DevOps team labels Mar 5, 2025
@HowardBraham HowardBraham linked a pull request Mar 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-dev-ops DevOps team team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants