diff --git a/.github/workflows/add-release-label.yml b/.github/workflows/add-release-label.yml index 2e34ad491b44..53f73c730696 100644 --- a/.github/workflows/add-release-label.yml +++ b/.github/workflows/add-release-label.yml @@ -18,7 +18,7 @@ jobs: fetch-depth: 0 # This is needed to checkout all branches - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Get the next semver version id: get-next-semver-version diff --git a/.github/workflows/build-beta.yml b/.github/workflows/build-beta.yml index 98a291edbb4f..c39228d30a69 100644 --- a/.github/workflows/build-beta.yml +++ b/.github/workflows/build-beta.yml @@ -42,7 +42,7 @@ jobs: - name: Setup environment if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }} - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Run beta build if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }} diff --git a/.github/workflows/build-storybook.yml b/.github/workflows/build-storybook.yml index e28b32556dbe..56ae72f4f02c 100644 --- a/.github/workflows/build-storybook.yml +++ b/.github/workflows/build-storybook.yml @@ -15,7 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Build storybook run: yarn storybook:build diff --git a/.github/workflows/check-attributions.yml b/.github/workflows/check-attributions.yml index cadaf0d1141b..af9bd7e1b886 100644 --- a/.github/workflows/check-attributions.yml +++ b/.github/workflows/check-attributions.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Check attributions changes run: yarn attributions:check diff --git a/.github/workflows/check-pr-labels.yml b/.github/workflows/check-pr-labels.yml index cc492c09319e..e564e0543aad 100644 --- a/.github/workflows/check-pr-labels.yml +++ b/.github/workflows/check-pr-labels.yml @@ -21,7 +21,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Check PR has required labels env: diff --git a/.github/workflows/check-template-and-add-labels.yml b/.github/workflows/check-template-and-add-labels.yml index e9c1c2844ca5..232b5e5d8a63 100644 --- a/.github/workflows/check-template-and-add-labels.yml +++ b/.github/workflows/check-template-and-add-labels.yml @@ -14,7 +14,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Check template and add labels id: check-template-and-add-labels diff --git a/.github/workflows/close-bug-report.yml b/.github/workflows/close-bug-report.yml index 46dcd0a9e9ff..328c5b4429b6 100644 --- a/.github/workflows/close-bug-report.yml +++ b/.github/workflows/close-bug-report.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Close release bug report issue env: diff --git a/.github/workflows/codespaces.yml b/.github/workflows/codespaces.yml deleted file mode 100644 index 5d37ba2d3dc3..000000000000 --- a/.github/workflows/codespaces.yml +++ /dev/null @@ -1,20 +0,0 @@ -name: 'Codespaces: update yarn cache' - -on: - push: - branches: - - 'codespaces**' - - 'main' - paths: - - '**/yarn.lock' - -jobs: - yarn-cache: - name: Generate cache image - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v4 - - - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main diff --git a/.github/workflows/fitness-functions.yml b/.github/workflows/fitness-functions.yml index f8e24692e8fe..0bb23232aaa1 100644 --- a/.github/workflows/fitness-functions.yml +++ b/.github/workflows/fitness-functions.yml @@ -17,7 +17,7 @@ jobs: fetch-depth: 0 # This is needed to checkout all branches - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Run fitness functions env: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5adec1fc7358..b61f2a3a7655 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,6 +6,7 @@ on: - main - master - Version-v* + - trigger-ci* pull_request: types: - opened @@ -16,7 +17,7 @@ on: jobs: lint-workflows: name: Lint workflows - uses: metamask/github-tools/.github/workflows/lint-workflows.yml@c534f265e02af2f2422a3c686bb09a11bfbf4cc2 + uses: metamask/github-tools/.github/workflows/lint-workflows.yml@1d657e262aea7e3f216754febb624831527d2565 test-lint-shellcheck: name: Test lint shellcheck @@ -28,7 +29,16 @@ jobs: test-circular-deps: name: Test circular deps - uses: ./.github/workflows/test-circular-deps.yml + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup environment + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 + + - name: Check circular dependencies + run: yarn circular-deps:check test-lint-changelog: name: Test lint changelog @@ -66,10 +76,52 @@ jobs: name: Validate lavamoat policy webapp uses: ./.github/workflows/validate-lavamoat-policy-webapp.yml + prep-build-test-browserify: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup environment + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 + + - run: yarn build:test + + - name: Upload artifact prep-build-test-browserify + uses: actions/upload-artifact@v4 + with: + name: prep-build-test-browserify + path: ./dist/ + + prep-build-test-webpack: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup environment + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 + + - run: yarn webpack --test --no-lavamoat --no-cache --browser=chrome --lockdown --sentry --snow --env production + env: + SEGMENT_PROD_WRITE_KEY: '-' # A fake key just to make the build succeed + + - name: Upload artifact prep-build-test-webpack + uses: actions/upload-artifact@v4 + with: + name: prep-build-test-webpack + path: ./dist/ + run-tests: name: Run tests uses: ./.github/workflows/run-tests.yml + run-benchmarks: + uses: ./.github/workflows/run-benchmarks.yml + needs: + - prep-build-test-browserify + - prep-build-test-webpack + wait-for-circleci-workflow-status: name: Wait for CircleCI workflow status uses: ./.github/workflows/wait-for-circleci-workflow-status.yml @@ -112,6 +164,8 @@ jobs: secrets: PR_COMMENT_TOKEN: ${{ secrets.PR_COMMENT_TOKEN }} + # Explanation for all-jobs-completed and all-jobs-pass being separate: + # https://github.com/MetaMask/metamask-module-template/pull/151 all-jobs-completed: name: All jobs completed runs-on: ubuntu-latest diff --git a/.github/workflows/publish-prerelease.yml b/.github/workflows/publish-prerelease.yml index f630bca8193d..84cee5279c6c 100644 --- a/.github/workflows/publish-prerelease.yml +++ b/.github/workflows/publish-prerelease.yml @@ -17,7 +17,7 @@ jobs: fetch-depth: 0 # This is needed to get merge base to calculate bundle size diff - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Get merge base commit hash id: get-merge-base diff --git a/.github/workflows/run-benchmarks.yml b/.github/workflows/run-benchmarks.yml new file mode 100644 index 000000000000..5ab185ef77c8 --- /dev/null +++ b/.github/workflows/run-benchmarks.yml @@ -0,0 +1,41 @@ +on: + workflow_call: + +env: + COMMANDS: | + { + pageload: 'yarn benchmark:chrome --out test-artifacts/chrome/benchmark/pageload.json --retries 2', + userActions: 'yarn user-actions-benchmark:chrome --out test-artifacts/chrome/benchmark/user_actions.json --retries 2', + } + +jobs: + benchmarks: + runs-on: ubuntu-22.04 + strategy: + matrix: + buildType: [browserify, webpack] + testType: [pageload, userActions] + name: ${{ matrix.buildType }}-${{ matrix.testType }} + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup environment + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 + + - name: Download artifact prep-build-test-${{ matrix.buildType }} + uses: actions/download-artifact@v4 + with: + path: ./dist/ + pattern: prep-build-test-${{ matrix.buildType }} + merge-multiple: true + + - name: Run the benchmark + # Choose a benchmark command from env.COMMANDS + run: ${{ fromJson(env.COMMANDS)[matrix.testType] }} + + - name: Upload Artifact + uses: actions/upload-artifact@v4 + with: + name: benchmark-${{ matrix.buildType }}-${{ matrix.testType }} + path: test-artifacts/chrome/benchmark/ diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 3cb7c50e573a..8307bdf833fd 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -22,7 +22,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: test:unit:coverage run: yarn test:unit:coverage --shard=${{ matrix.shard }}/${{ strategy.job-total }} @@ -43,7 +43,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: test:unit:webpack:coverage run: yarn test:unit:webpack:coverage @@ -64,7 +64,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: test:integration:coverage run: yarn test:integration:coverage @@ -92,12 +92,13 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Download artifacts uses: actions/download-artifact@v4 with: path: coverage + pattern: coverage-* merge-multiple: true - name: Merge coverage reports diff --git a/.github/workflows/test-circular-deps.yml b/.github/workflows/test-circular-deps.yml deleted file mode 100644 index 5f3024c3f81a..000000000000 --- a/.github/workflows/test-circular-deps.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: Test Circular Dependencies - -on: - workflow_call: - -jobs: - test-circular-deps: - name: Test circular dependencies - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v4 - - - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main - - - name: Check circular dependencies - run: yarn circular-deps:check \ No newline at end of file diff --git a/.github/workflows/test-deps-audit.yml b/.github/workflows/test-deps-audit.yml index 271746da2429..4001735c6ad2 100644 --- a/.github/workflows/test-deps-audit.yml +++ b/.github/workflows/test-deps-audit.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Run audit run: yarn audit diff --git a/.github/workflows/test-deps-depcheck.yml b/.github/workflows/test-deps-depcheck.yml index 3860c485f25b..baf3c13f41a3 100644 --- a/.github/workflows/test-deps-depcheck.yml +++ b/.github/workflows/test-deps-depcheck.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Run depcheck run: yarn depcheck diff --git a/.github/workflows/test-lint-changelog.yml b/.github/workflows/test-lint-changelog.yml index 9e8ee0e992c8..8f014f4c8065 100644 --- a/.github/workflows/test-lint-changelog.yml +++ b/.github/workflows/test-lint-changelog.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Validate changelog # For a `pull_request` event, the branch is `github.head_ref``. diff --git a/.github/workflows/test-lint-lockfile.yml b/.github/workflows/test-lint-lockfile.yml index cc84318624ce..153a13c3fc3b 100644 --- a/.github/workflows/test-lint-lockfile.yml +++ b/.github/workflows/test-lint-lockfile.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Lint lockfile run: yarn lint:lockfile diff --git a/.github/workflows/test-lint.yml b/.github/workflows/test-lint.yml index df40a3a7ef27..205377a376c2 100644 --- a/.github/workflows/test-lint.yml +++ b/.github/workflows/test-lint.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Lint run: yarn lint diff --git a/.github/workflows/test-storybook.yml b/.github/workflows/test-storybook.yml index 8e3ddba53587..89cd695e1413 100644 --- a/.github/workflows/test-storybook.yml +++ b/.github/workflows/test-storybook.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Install Playwright browsers run: yarn exec playwright install chromium diff --git a/.github/workflows/test-yarn-dedupe.yml b/.github/workflows/test-yarn-dedupe.yml index 40bda1dfb3d2..2d9c9864bbc6 100644 --- a/.github/workflows/test-yarn-dedupe.yml +++ b/.github/workflows/test-yarn-dedupe.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Detect yarn lock deduplications run: yarn dedupe --check diff --git a/.github/workflows/update-attributions.yml b/.github/workflows/update-attributions.yml index 3e107d324216..85ba21f468b5 100644 --- a/.github/workflows/update-attributions.yml +++ b/.github/workflows/update-attributions.yml @@ -59,7 +59,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Get commit SHA id: commit-sha run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT" @@ -81,7 +81,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Generate Attributions run: yarn attributions:generate - name: Cache attributions file @@ -182,4 +182,4 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.LAVAMOAT_UPDATE_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - ACTION_RUN_URL: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" + ACTION_RUN_URL: '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}' diff --git a/.github/workflows/update-lavamoat-policies.yml b/.github/workflows/update-lavamoat-policies.yml index 09ab6b304a6a..d138733937cb 100644 --- a/.github/workflows/update-lavamoat-policies.yml +++ b/.github/workflows/update-lavamoat-policies.yml @@ -59,7 +59,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.LAVAMOAT_UPDATE_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Get commit SHA id: commit-sha run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT" @@ -78,7 +78,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.LAVAMOAT_UPDATE_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Update LavaMoat build policy run: yarn lavamoat:build:auto - name: Cache build policy @@ -107,7 +107,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.LAVAMOAT_UPDATE_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Restore build policy uses: actions/cache/restore@v4 with: @@ -264,4 +264,4 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.LAVAMOAT_UPDATE_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - ACTION_RUN_URL: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" + ACTION_RUN_URL: '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}' diff --git a/.github/workflows/validate-lavamoat-allow-scripts.yml b/.github/workflows/validate-lavamoat-allow-scripts.yml index 637a2d9aeb54..df680b2bb5d0 100644 --- a/.github/workflows/validate-lavamoat-allow-scripts.yml +++ b/.github/workflows/validate-lavamoat-allow-scripts.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Validate allow-scripts config run: yarn allow-scripts auto diff --git a/.github/workflows/validate-lavamoat-policy-build.yml b/.github/workflows/validate-lavamoat-policy-build.yml index 4524cc26a546..eed9d3f471bd 100644 --- a/.github/workflows/validate-lavamoat-policy-build.yml +++ b/.github/workflows/validate-lavamoat-policy-build.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Validate lavamoat build policy run: yarn lavamoat:build:auto diff --git a/.github/workflows/validate-lavamoat-policy-webapp.yml b/.github/workflows/validate-lavamoat-policy-webapp.yml index 37ff9ede00fc..2daa15f00cb9 100644 --- a/.github/workflows/validate-lavamoat-policy-webapp.yml +++ b/.github/workflows/validate-lavamoat-policy-webapp.yml @@ -15,7 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Validate lavamoat ${{ matrix.build-type }} policy run: yarn lavamoat:webapp:auto:ci --build-types=${{ matrix.build-type }} diff --git a/.github/workflows/validate-page-object-usage.yml b/.github/workflows/validate-page-object-usage.yml index 71296ef47540..c44c96067900 100644 --- a/.github/workflows/validate-page-object-usage.yml +++ b/.github/workflows/validate-page-object-usage.yml @@ -17,7 +17,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: metamask/github-tools/.github/actions/setup-environment@main + uses: metamask/github-tools/.github/actions/setup-environment@1d657e262aea7e3f216754febb624831527d2565 - name: Run E2E Page Object Usage Validation env: @@ -26,4 +26,4 @@ jobs: BRANCH: ${{ github.head_ref || github.ref_name }} HEAD_COMMIT_HASH: ${{ github.event.pull_request.head.sha || github.sha }} run: | - yarn validate-e2e-page-object-usage \ No newline at end of file + yarn validate-e2e-page-object-usage diff --git a/.github/workflows/wait-for-circleci-workflow-status.yml b/.github/workflows/wait-for-circleci-workflow-status.yml index 30efc6d35776..9c3c58f3aabc 100644 --- a/.github/workflows/wait-for-circleci-workflow-status.yml +++ b/.github/workflows/wait-for-circleci-workflow-status.yml @@ -30,7 +30,8 @@ jobs: done fi - if [ "$workflow_status" != "success" ]; then + # The "not_run" only happens when you're developing CI workflows and testing weird cases + if [ "$workflow_status" != "success" ] && [ "$workflow_status" != "not_run" ]; then echo "::error::Workflow status is '$workflow_status'. Exiting with error." exit 1 fi diff --git a/test/e2e/webdriver/chrome.js b/test/e2e/webdriver/chrome.js index fa56c107439e..32a55bfc6dee 100644 --- a/test/e2e/webdriver/chrome.js +++ b/test/e2e/webdriver/chrome.js @@ -61,7 +61,7 @@ class ChromeDriver { args.push('--disable-gpu'); } - if (isHeadless('SELENIUM')) { + if (process.env.GITHUB_ACTION || isHeadless('SELENIUM')) { // TODO: Remove notice and consider non-experimental when results are consistent console.warn( '*** Running e2e tests in headless mode is experimental and some tests are known to fail for unknown reasons',