test: Add basic tests for SnapUIRenderer #30099
Merged
+1,402
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [8ce28bc]
Page Load Metrics (1626 ± 46 ms)
Bundle size diffs
|
Builds ready [8193410]
Page Load Metrics (1567 ± 46 ms)
Bundle size diffs
|
Builds ready [17f8f62]
Page Load Metrics (1736 ± 60 ms)
Bundle size diffs
|
Builds ready [52c195d]
Page Load Metrics (1987 ± 99 ms)
Bundle size diffs
|
Builds ready [8d48d24]
Page Load Metrics (1778 ± 75 ms)
Bundle size diffs
|
Builds ready [25fb3b2]
Page Load Metrics (1746 ± 66 ms)
Bundle size diffs
|
FrederikBolding
force-pushed
the
fb/snap-ui-renderer-tests
branch
from
13fb039 to
debbc76
Compare
Builds ready [debbc76]
Page Load Metrics (1725 ± 60 ms)
Bundle size diffs
|
FrederikBolding
force-pushed
the
fb/snap-ui-renderer-tests
branch
from
1406bd8 to
305a552
Compare
Builds ready [305a552]
Page Load Metrics (1777 ± 74 ms)
Bundle size diffs
|
Mrtenz
approved these changes
Feb 7, 2025
david0xd
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hmalik88
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Could be a good idea to group the tests especially since this file will probably grow large:
describe('SnapUIRenderer', () => {
describe('Basic Rendering', () => {
// loading, basic UI tests
});
describe('Form Handling', () => {
// form, input tests
});
describe('State Management', () => {
// re-render, state sync tests
});
});
metamaskbot
added
the
release-12.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Establishes a base level of unit testing for the
SnapUIRendererincluding some snapshot and performance tests.Related issues
Closes MetaMask/snaps#3060