Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix snaps permission flow ui (#30116) #30132

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Feb 5, 2025

Issue described
here

This commit fixes the snaps permission flow UI bug detected after #29824

Screenshots after fix:

Screenshot 2025-02-04 at 20 20 37 Screenshot 2025-02-04 at 20 20 53

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Issue described
[here](#30087)

This commit fixes the snaps permission flow UI bug detected after
#29824

Screenshots after fix:


<img width="349" alt="Screenshot 2025-02-04 at 20 20 37"
src="https://github.com/user-attachments/assets/968d3d48-c6e4-4283-9c64-a5a28dc968dc"
/>
<img width="337" alt="Screenshot 2025-02-04 at 20 20 53"
src="https://github.com/user-attachments/assets/ebb73ffe-cd54-446f-aaf1-7da895dad0f0"
/>



<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30116?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@ffmcgee725 ffmcgee725 marked this pull request as ready for review February 5, 2025 13:43
@ffmcgee725 ffmcgee725 requested a review from a team as a code owner February 5, 2025 13:43
@ffmcgee725 ffmcgee725 merged commit 0e7c02c into Version-v12.12.0 Feb 5, 2025
62 of 63 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/cherry-pick-snaps-ui-flow-fix branch February 5, 2025 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0f3f9a7]
Page Load Metrics (1565 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1440171015657335
domContentLoaded1425169215446933
load1440171315657234
domInteractive2488392010
backgroundConnect87325178
firstReactRender1689472713
getState448994
initialActions01000
loadScripts1016126611156230
setupStore74919168
uiStartup16002198180613464

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants