Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mmassets-543 #30133

Merged

Conversation

jpsains
Copy link
Contributor

@jpsains jpsains commented Feb 5, 2025

Description

Bug fix: Do not show users' balance tool-tip when in privacy mode.

Open in GitHub Codespaces

Related issues

Fixes:
#29236
https://consensyssoftware.atlassian.net/browse/MMASSETS-534

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpsains jpsains force-pushed the MMASSETS-534-turn-off-hover-for-amounts-when-privacy-mode-is-on branch from e0f25a3 to 13daa8d Compare February 5, 2025 13:47
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 5, 2025
@jpsains
Copy link
Contributor Author

jpsains commented Feb 5, 2025

I have read the CLA Document and I hereby sign the CLA

@jpsains jpsains added team-assets and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [657c3d0]
Page Load Metrics (1825 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25521091725374180
domContentLoaded15732200179718086
load15832205182518489
domInteractive2510041199
backgroundConnect1173332210
firstReactRender16108542914
getState587172110
initialActions01000
loadScripts11021650131015374
setupStore893262713
uiStartup177529192131273131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpsains jpsains added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit c09f80b Feb 5, 2025
72 checks passed
@jpsains jpsains deleted the MMASSETS-534-turn-off-hover-for-amounts-when-privacy-mode-is-on branch February 5, 2025 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants