Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: chore: Use network-specific smart transaction feature flags (#30094) #30136

Merged

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Feb 5, 2025

Description

Cherry pick of: #30094

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Turn off some feature flag which is network-specific for smart transactions (e.g. bsc.smartTransactions.extensionActive = false)
  2. See that it's being used over a shared one (smartTransactions.extensionActive)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**
If there are network-specific feature flags for smart transactions, they
will take priority over shared smart transaction feature flags.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30094?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Turn off some feature flag which is network-specific for smart
transactions (e.g. `bsc.smartTransactions.extensionActive = false`)
2. See that it's being used over a shared one
(`smartTransactions.extensionActive`)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Feb 5, 2025
@metamaskbot metamaskbot added the team-transactions Transactions team label Feb 5, 2025
@itsyoboieltr itsyoboieltr merged commit 1dbc743 into Version-v12.12.0 Feb 5, 2025
68 checks passed
@itsyoboieltr itsyoboieltr deleted the chain-specific-feature-flags-cherry-pick branch February 5, 2025 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [45bc2f3]
Page Load Metrics (2093 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24923271466794381
domContentLoaded16132383206920197
load16502395209319895
domInteractive23204664622
backgroundConnect106831199
firstReactRender17111502713
getState667312211
initialActions01000
loadScripts11841798155317484
setupStore86315115
uiStartup193832052426275132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants