Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Dec 1, 2025

Description

Added web3auth as co-owner for confirmations folder > shield-subscription-info

Open in GitHub Codespaces

Changelog

CHANGELOG entry: N/A

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit c26f6f1. Configure here.

@lionellbriones lionellbriones requested a review from a team as a code owner December 1, 2025 10:05
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Dec 1, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔒 @MetaMask/extension-security-team (1 files, +1 -0)
  • 📁 .github/
    • 📄 CODEOWNERS +1 -0

@metamaskbot
Copy link
Collaborator

Builds ready [c26f6f1]
UI Startup Metrics (1248 ± 115 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12481048167711513251417
load1051875143010010951204
domContentLoaded104587114229910891195
domInteractive2816169282290
firstPaint5088513753989611206
backgroundConnect22020026012229243
firstReactRender322066103953
getState3517112164357
initialActions105112
loadScripts830661117397881991
setupStore1273451324
numNetworkReqs1257520572
BrowserifyPower User HomeuiStartup20631715315226422702559
load100287317811459931354
domContentLoaded98786517451449781347
domInteractive34171482631106
firstPaint5669717534079491301
backgroundConnect249202734107225543
firstReactRender5741131136281
getState19813767897202341
initialActions104112
loadScripts78466914791387751138
setupStore2074872236
numNetworkReqs1596941479203376
WebpackStandard HomeuiStartup8337011206888691010
load64056787673685802
domContentLoaded63656387272680797
domInteractive2716147232293
firstPaint226102794160199633
backgroundConnect125258251225
firstReactRender27206063136
getState281450113848
initialActions104111
loadScripts63356186271679789
setupStore1062641118
numNetworkReqs1257820571
WebpackPower User HomeuiStartup16771267242828419662221
load6805821117100684953
domContentLoaded6705771110101674947
domInteractive36191623033120
firstPaint267891133190253698
backgroundConnect91864518719585
firstReactRender61449196678
getState18214369274179229
initialActions102112
loadScripts667575110199671937
setupStore211053102447
numNetworkReqs1746643787219419
FirefoxBrowserifyStandard HomeuiStartup13131089204515713911606
load1098937147910411461332
domContentLoaded1098937147910411461332
domInteractive67311553290124
firstPaint------
backgroundConnect46221833051120
firstReactRender22185152232
getState136202231021
initialActions102122
loadScripts106991914589311181286
setupStore126128151031
numNetworkReqs1157016662
BrowserifyPower User HomeuiStartup26531919495163627214177
load1206984264433511652406
domContentLoaded1206979264433511652406
domInteractive11035482100106418
firstPaint------
backgroundConnect140271621218118355
firstReactRender6140236246596
getState25268938192276704
initialActions2026322
loadScripts1144958240925411061496
setupStore1407817190117648
numNetworkReqs102643316483249
WebpackStandard HomeuiStartup15321309213115615941846
load12611074160110013141438
domContentLoaded12601074160010013141437
domInteractive69272343884130
firstPaint------
backgroundConnect52182523566118
firstReactRender28218683041
getState157173211225
initialActions103122
loadScripts1232105815839312891370
setupStore166206261154
numNetworkReqs1256817764
WebpackPower User HomeuiStartup29702256578773330154502
load14771180299843214152784
domContentLoaded14771179299843214152783
domInteractive11030452107103441
firstPaint------
backgroundConnect134291155157134302
firstReactRender69412683670153
getState30461914235428837
initialActions218123
loadScripts14221154278636713652446
setupStore13171029184150579
numNetworkReqs102592535988244
📊 Page Load Benchmark Results

Current Commit: c26f6f1 | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 715ms (±35ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 37ms 1.00s 1.30s 1.06s 1.30s
domContentLoaded 715ms 35ms 697ms 972ms 751ms 972ms
firstPaint 76ms 10ms 60ms 156ms 84ms 156ms
firstContentfulPaint 76ms 10ms 60ms 156ms 84ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@lionellbriones lionellbriones added team-shield Shield team and removed team-onboarding Onboarding team labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants