From 4cf490a518063ded9e175debb9683cd92253ffaf Mon Sep 17 00:00:00 2001 From: Prithpal Sooriya Date: Mon, 1 Dec 2025 18:50:07 +0000 Subject: [PATCH] test: add back skipped solana tests adding driver delay as these tests rely on snap balances which are async --- test/e2e/tests/send/send-solana.spec.ts | 6 +++--- test/e2e/tests/solana/check-balance.spec.ts | 10 ++++------ test/e2e/tests/solana/send-flow.spec.ts | 5 ++--- .../e2e/tests/solana/transaction-activity-list.spec.ts | 7 ++++--- 4 files changed, 13 insertions(+), 15 deletions(-) diff --git a/test/e2e/tests/send/send-solana.spec.ts b/test/e2e/tests/send/send-solana.spec.ts index 6a501ae16a32..a5ec99328a9d 100644 --- a/test/e2e/tests/send/send-solana.spec.ts +++ b/test/e2e/tests/send/send-solana.spec.ts @@ -5,9 +5,7 @@ import { DEFAULT_SOLANA_TEST_DAPP_FIXTURE_OPTIONS } from '../../flask/solana-wal import { withSolanaAccountSnap } from '../solana/common-solana'; import { mockSendRedesignFeatureFlag } from './common'; -// BUG #37824 With BIP44 turned on balance on Solana is always zero even when it is mocked -// eslint-disable-next-line mocha/no-skipped-tests -describe.skip('Send Solana', function () { +describe('Send Solana', function () { it('it should be possible to send SOL', async function () { await withSolanaAccountSnap( { @@ -23,6 +21,8 @@ describe.skip('Send Solana', function () { driver, ); + await driver.delay(5000); + await nonEvmHomepage.clickOnSendButton(); // Navigating immediate will not work - we wait in the asset page to catch up diff --git a/test/e2e/tests/solana/check-balance.spec.ts b/test/e2e/tests/solana/check-balance.spec.ts index 9fdb4a812079..5fd844ccf675 100644 --- a/test/e2e/tests/solana/check-balance.spec.ts +++ b/test/e2e/tests/solana/check-balance.spec.ts @@ -83,9 +83,7 @@ describe('Check balance', function (this: Suite) { }, ); }); - // BUG #37824 With BIP44 turned on mocking Solana network responses no longer works - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('For a non 0 balance account - USD balance', async function () { + it('For a non 0 balance account - USD balance', async function () { await withSolanaAccountSnap( { title: this.test?.fullTitle(), @@ -95,13 +93,12 @@ describe('Check balance', function (this: Suite) { }, async (driver) => { const homePage = new NonEvmHomepage(driver); + await driver.delay(5000); await homePage.checkGetBalance('$5,643.50', 'USD'); }, ); }); - // BUG #37824 With BIP44 turned on mocking Solana network responses no longer works - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('For a non 0 balance account - SOL balance', async function () { + it('For a non 0 balance account - SOL balance', async function () { await withSolanaAccountSnap( { title: this.test?.fullTitle(), @@ -109,6 +106,7 @@ describe('Check balance', function (this: Suite) { }, async (driver) => { const homePage = new NonEvmHomepage(driver); + await driver.delay(5000); await homePage.checkGetBalance('50', 'SOL'); }, ); diff --git a/test/e2e/tests/solana/send-flow.spec.ts b/test/e2e/tests/solana/send-flow.spec.ts index 8bd6aa5311b7..6c09b44b89ab 100644 --- a/test/e2e/tests/solana/send-flow.spec.ts +++ b/test/e2e/tests/solana/send-flow.spec.ts @@ -9,9 +9,7 @@ import { withSolanaAccountSnap } from './common-solana'; const commonSolanaAddress = 'GYP1hGem9HBkYKEWNUQUxEwfmu4hhjuujRgGnj5LrHna'; -// BUG #37824 - With BIP44 turned on mocking Solana network responses no longer works -// eslint-disable-next-line mocha/no-skipped-tests -describe.skip('Send flow', function (this: Suite) { +describe('Send flow', function (this: Suite) { it('with some field validation', async function () { this.timeout(120000); await withSolanaAccountSnap( @@ -200,6 +198,7 @@ describe.skip('Send flow', function (this: Suite) { mockGetTransactionSuccess: true, }, async (driver) => { + await driver.delay(5000); const homePage = new NonEvmHomepage(driver); await homePage.checkPageIsLoaded('50'); assert.equal( diff --git a/test/e2e/tests/solana/transaction-activity-list.spec.ts b/test/e2e/tests/solana/transaction-activity-list.spec.ts index 24908abc74df..019b05a5dc62 100644 --- a/test/e2e/tests/solana/transaction-activity-list.spec.ts +++ b/test/e2e/tests/solana/transaction-activity-list.spec.ts @@ -9,9 +9,7 @@ import { withSolanaAccountSnap, } from './common-solana'; -// BUG #37824 - With BIP44 turned on mocking Solana network responses no longer works -// eslint-disable-next-line mocha/no-skipped-tests -describe.skip('Transaction activity list', function (this: Suite) { +describe('Transaction activity list', function (this: Suite) { it('user can see activity list and a confirmed transaction details', async function () { this.timeout(120000); await withSolanaAccountSnap( @@ -24,6 +22,7 @@ describe.skip('Transaction activity list', function (this: Suite) { const homePage = new NonEvmHomepage(driver); await homePage.goToActivityList(); + await driver.delay(5000); const activityList = new ActivityListPage(driver); await activityList.checkTxAction({ action: 'Sent' }); await activityList.checkTxAmountInActivity('-0.00708 SOL', 1); @@ -61,6 +60,8 @@ describe.skip('Transaction activity list', function (this: Suite) { const homePage = new NonEvmHomepage(driver); await homePage.checkPageIsLoaded('50'); await homePage.goToActivityList(); + + await driver.delay(5000); const activityList = new ActivityListPage(driver); await activityList.checkFailedTxNumberDisplayedInActivity(1); await activityList.checkTxAction({ action: 'Interaction' });