fix: fixes recipient modal long text overflow #38454
Open
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (2 files, +27 -8)
|
SteP-n-s
previously approved these changes
Dec 1, 2025
Collaborator
Builds ready [d471ade]
UI Startup Metrics (1239 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
previously approved these changes
Dec 1, 2025
Collaborator
Builds ready [17f58cd]
UI Startup Metrics (1229 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The destination account picker modal was experiencing horizontal overflow when account names were long (e.g., external addresses used as names). This created a poor UX with horizontal scrolling.
The fix adds proper overflow handling to the account name container:
overflow: hidden,flex: 1, andminWidth: 0to the Column containing the name (theminWidth: 0is key for flex children to allow shrinking below content size)overflow: hiddento the RowtextOverflow: ellipsisto the Text componentflexShrink: 0to the checkmark icon so it doesn't get squishedNow long account names are properly truncated with an ellipsis instead of causing overflow.
Changelog
CHANGELOG entry: Fixed recipient modal overflow when account names are long
Related issues
Fixes: #38107
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Prevents horizontal overflow in the destination account picker by constraining flex children and adding ellipsis truncation; updates snapshots accordingly.
ui/pages/bridge/prepare/components/destination-account-list-item.tsx:style={{ overflow: 'hidden', flex: 1, minWidth: 0 }}toColumnwrapping the name.Rowtostyle={{ overflow: 'hidden' }}andTexttostyle={{ overflow: 'hidden', textOverflow: 'ellipsis' }}withellipsisprop.style={{ flexShrink: 0 }}.__snapshots__/destination-account-picker-modal.test.tsx.snapto reflect new overflow, flex, and ellipsis styles.Written by Cursor Bugbot for commit 17f58cd. This will update automatically on new commits. Configure here.