Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Dec 2, 2025

Description

This PR adds Shield activity to rewards pts estimation.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: estimate rewards points for shield subscription

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Dec 2, 2025
@github-actions github-actions bot added the size-S label Dec 2, 2025
@lwin-kyaw lwin-kyaw requested a review from VGR-GIT December 2, 2025 04:32
@metamaskbot
Copy link
Collaborator

Builds ready [41c3aac]
UI Startup Metrics (1271 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12711038178110013281421
load105888014588410921211
domContentLoaded105387714398310891205
domInteractive2816183242384
firstPaint48710512023839871132
backgroundConnect22520326512231252
firstReactRender322068113952
getState4114142224678
initialActions105112
loadScripts833673119282869983
setupStore1363451422
numNetworkReqs1257720572
BrowserifyPower User HomeuiStartup20311689264420821232447
load1019897147111410231343
domContentLoaded1005891146511610101333
domInteractive3318110203493
firstPaint55610714193919681317
backgroundConnect23520265266231261
firstReactRender58421281759103
getState19014167772191232
initialActions107113
loadScripts79669512401137991109
setupStore21114792344
numNetworkReqs1576937558208261
WebpackStandard HomeuiStartup8246991182868651000
load64756185376685802
domContentLoaded64355784676682797
domInteractive2615103202287
firstPaint21476795143207630
backgroundConnect1064571125
firstReactRender27205563137
getState24134793241
initialActions103111
loadScripts64055583774680787
setupStore1052231218
numNetworkReqs1257419571
WebpackPower User HomeuiStartup15701235219422616601978
load664581109189673880
domContentLoaded655576107989658873
domInteractive35181572832119
firstPaint289831088217287740
backgroundConnect46763512018415
firstReactRender57437976270
getState193132732107180243
initialActions103012
loadScripts652574107087656861
setupStore21961132254
numNetworkReqs1616940868211283
FirefoxBrowserifyStandard HomeuiStartup12801081186115513511642
load106292613179811401253
domContentLoaded106292513179811401253
domInteractive64331953686139
firstPaint------
backgroundConnect43231782844106
firstReactRender22175052334
getState1165981023
initialActions102012
loadScripts103690912999210951227
setupStore1153771032
numNetworkReqs1256918664
BrowserifyPower User HomeuiStartup26542027432845627544037
load12371023249326312711712
domContentLoaded12371023249326312701712
domInteractive13139981123126366
firstPaint------
backgroundConnect152301100184135654
firstReactRender61361662463111
getState25651855193336721
initialActions2135427
loadScripts11941002243924512201683
setupStore1726799220166743
numNetworkReqs93633254987232
WebpackStandard HomeuiStartup15261314193913616071800
load12491091159810713371431
domContentLoaded12481090159710613371431
domInteractive61271763382129
firstPaint------
backgroundConnect49211803050122
firstReactRender27197483138
getState147148171347
initialActions215134
loadScripts1219107315669913121389
setupStore176141221377
numNetworkReqs1257117762
WebpackPower User HomeuiStartup30112090606083030564914
load15401157317648315622841
domContentLoaded15401157317648315622841
domInteractive132301032148107421
firstPaint------
backgroundConnect2253113073161501070
firstReactRender63402803160112
getState300441254254474818
initialActions207123
loadScripts14421138301236515182413
setupStore1388768188128670
numNetworkReqs90592344093204
📊 Page Load Benchmark Results

Current Commit: 41c3aac | Date: 12/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 981ms (±37ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 680ms (±35ms) 🟢 | historical mean value: 732ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 981ms 37ms 957ms 1.25s 1.01s 1.25s
domContentLoaded 680ms 35ms 659ms 925ms 705ms 925ms
firstPaint 75ms 11ms 64ms 172ms 84ms 172ms
firstContentfulPaint 75ms 11ms 64ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@lwin-kyaw lwin-kyaw added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 50cc11f Dec 2, 2025
191 of 193 checks passed
@lwin-kyaw lwin-kyaw deleted the feat/shield-rewards-integration branch December 2, 2025 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
@metamaskbot metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.13.0 Issue or pull request that will be included in release 13.13.0 size-S team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants