chore(stellar): stellar preparation PR - 3 - #34527
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
🧪 Flaky unit test detectionRun history flaky detectionHistorical failure rate is a hint, not proof — review each suggestion in context. See the flaky-test-detection skill for the full pattern reference and manual audit workflow. Failures / runs sampled per window:
AI-detected flaky patterns
|
| allNetworkConfigs?: Record<string, { nativeCurrency?: string } | undefined>; | ||
| solanaAccount?: { id: string }; | ||
| tronAccount?: { id: string }; | ||
| stellarAccount?: { id: string }; |
There was a problem hiding this comment.
this is for quick buy and sell, safe for added when only activate if stellar account exist + bridge FF activate
| @@ -82,6 +83,7 @@ export const usePayWithTokens = (): { | |||
| allNetworkConfigs, | |||
| solanaAccount: solanaAccount ?? undefined, | |||
There was a problem hiding this comment.
this is for quick buy and sell, safe for added when only activate if stellar account exist + bridge FF activate
| @@ -170,6 +173,7 @@ export const usePositionTokenBalance = ( | |||
| allNetworkConfigs, | |||
| solanaAccount: solanaAccount ?? undefined, | |||
There was a problem hiding this comment.
this is for quick buy and sell, safe for added when only activate if stellar account exist + bridge FF activate
| @@ -137,6 +138,7 @@ export const useReceiveTokens = ( | |||
| ); | |||
| const solanaAccount = selectAccountByScope(SolScope.Mainnet); | |||
There was a problem hiding this comment.
this is for quick buy and sell, safe for added when only activate if stellar account exist + bridge FF activate
| continue; | ||
| } | ||
| // We just need stellar pubnet, at least for now | ||
| if ( |
There was a problem hiding this comment.
no where is consuming buy only earn screen, stellar does not have token to EARN as for now, we add it just to align with other non-evm
stanleyyconsensys
added
the
no-changelog
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd875bc. Configure here.
|
|
||
| if (hasSelectedAccounts.stellar) { | ||
| accountSelectionFlags.push(areAllStellarNetworksSelected); | ||
| } |
There was a problem hiding this comment.
Select-all breaks with Stellar kill switch
Medium Severity
areAllNetworksSelectedCombined treats a present Stellar account as requiring all Stellar networks selected, but Stellar network configs are removed when selectIsStellarAccountsEnabled is off. After a remote kill switch, stellarNetworks is empty so areAllStellarNetworksSelected stays false, and the Network Manager “All popular networks” control stays unselected even when every visible network is selected.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit cd875bc. Configure here.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #34527 +/- ##
==========================================
- Coverage 85.12% 85.11% -0.02%
==========================================
Files 6350 6369 +19
Lines 173080 173715 +635
Branches 42804 42983 +179
==========================================
+ Hits 147333 147852 +519
- Misses 15708 15777 +69
- Partials 10039 10086 +47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
3 participants
Description
Stellar is not live yet, it should have no impact to UX
Adds Stellar (pubnet) plumbing ahead of full Stellar accounts UI, following the same patterns as Bitcoin and Tron.
Wires
selectIsStellarAccountsEnabled(existingstellarAccountsremote flag, prod default off) intoselectNonEvmNetworkConfigurationsByChainIdso Stellar pubnet is only included when the flag is on. Adds Stellar network metadata (decimals, ticker, image) and account-scope handling forXlmScope.Pubnet, plus selector/test coverage.Updates
useNetworksToUseso Stellar networks are only mixed into network pickers when a Stellar account exists in the selected group (same account-gated pattern as Solana/BTC/Tron). AddsXlmScope.Pubnetto popular-network classification sets — these only classify already-configured networks, so with the flag off Stellar still does not appear in Network Manager.Wires Stellar into Bridge source-network fiat sorting (
useSortedSourceNetworks) for when pubnet is already an enabled source chain. Extends Social QuickBuy hooks to resolve Stellar account/balances by scope (no-ops without a Stellar account). Updates related NetworkMultiSelector / CustomNetworkSelector tests.Intentionally omitted from this PR: Trending / Hot Tokens (
trendingNetworksList,useTrendingRequest) — Stellar is already in the trending API, and token details Receive currently falls back to the selected EVM address when no Stellar account exists. We’ll enable Explore/Trending together with accounts at launch.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Stellar is not live yet, it should have no impact to UX
Screen.Recording.2026-08-10.at.12.26.56.mov
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches network configuration, token lists, Bridge sorting, and Trending API chain sets, but Stellar paths are gated by a remote flag defaulting off; main risk is accidental exposure or API calls if gating is wrong.
Overview
Adds Stellar pubnet support across multichain networking, Bridge, Quick Buy, and Trending, following the same patterns as Tron/Bitcoin and keeping behavior off until
selectIsStellarAccountsEnabledis true.Networks & selectors:
selectNonEvmNetworkConfigurationsByChainIdonly exposes pubnet when the flag is on (metadata +getActiveNetworksByScopesforXlmScope.Pubnet).useNetworksToUseloads the Stellar namespace and merges Stellar networks only when a Stellar account exists in the selected group.XlmScope.Pubnetis added to popular-network chain ID sets; non-EVM token merging is limited to pubnet forstellar:chains.Bridge & Quick Buy: Bridge source-network sorting includes Stellar fiat totals via
XlmScope.Pubnet. Quick Buy balance/receive/pay hooks resolve a Stellar account and include pubnet in stablecoin receive candidates.Trending: New
useTrendingChainIdscentralizes default chain IDs and drops Stellar when accounts are disabled;useTrendingRequest,useSearchRequest, andTrendingTokensFullViewuse it so Explore network filters and API calls stay aligned with the flag.Test mocks are updated for the expanded
useNetworksToUsereturn shape and Stellar scenarios.Reviewed by Cursor Bugbot for commit d5e5fe8. Bugbot is set up for automated code reviews on this repo. Configure here.