fix: cp-7.60.0 use correct chainId collectibles for nft send flow

[Prithpal-Sooriya]

Description

The underlying sendflow uses selectChainId which should be marked as deprecated.

• This selected does not return the correct chain ID when you are using "Popular Networks" view as you can have multiple chainIDs selected now!!

This has unearthed a very large scope at this selector underpins many areas in mobile and extension 💀
Ideally all flows and features should move away from this selector and handle multiple selected chainIDs.

Changelog

CHANGELOG entry: fix: correct nft images available during send flow

Related issues

Fixes: #20982

Manual testing steps

1. Select Popular Networks Tab
2. Go through NFT send flow - Select NFT from (e.g.) Linea (not ethereum)
3. Expected: On review page, should see NFT and can select NFT image without crashing app

Screenshots/Recordings

Before

After

https://www.loom.com/share/683675a4c01b47b0a99f6ff5e9dfa30a

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Fetch NFTs by the correct hex chainId via a new selector in the send flow, refine HeroNft placeholder/interaction, and add selector tests with deprecation notes for legacy selectors.

• State/Selectors:
  • New reducers/collectibles/selectAllCollectiblesByChain: returns collectibles for selected address and given Hex chainId; includes unit tests.
  • Deprecate collectiblesSelector and selectChainId (comments only).
• Hooks:
  • Update useNft to use selectAllCollectiblesByChain and hexified chainId; derive NFT by tokenId.
• UI:
  • HeroNft placeholder: remove "Show" text, only show #tokenId when available; block navigation when no NFT.
  • Tests updated and expanded (placeholder interaction, image from collection.imageUrl, assertions).

^{Written by Cursor Bugbot for commit 0247941. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeNetworkAbstractions, SmokeAssets, SmokeConfirmationsRedesigned, SmokeWalletPlatform
• Risk Level: medium
• AI Confidence: 85%

click to see 🤖 AI reasoning details

These changes address multi-chain network selection issues and NFT display in confirmations. Here's the breakdown:

Changes Made:

1. Deprecated selectChainId selector with warning about multi-network selection reliability
2. Created new chain-specific collectibles selector selectAllCollectiblesByChain
3. Deprecated old collectiblesSelector that doesn't work with multiple networks
4. Updated NFT display hook to use new chain-specific selector
5. Improved hero-nft component safety and null handling in confirmation flows

Risk Assessment - MEDIUM:

• Network selector deprecation is marked as CRITICAL file but only adds documentation (no logic change)
• New collectibles selector changes how NFTs are retrieved (chain-specific vs global)
• Multiple components use the deprecated selectors (30+ usages of selectChainId found)
• Changes affect confirmation flows where NFTs are displayed
• The deprecated selectors are still functional, just marked for future replacement

Tag Selection Rationale:

1. SmokeNetworkAbstractions (HIGH priority) - Critical file changed with network selector deprecation. Multi-chain logic is being updated to handle "popular networks" (multiple selected networks) properly.

2. SmokeAssets (HIGH priority) - Core changes to collectibles/NFT selectors and display logic. New selector fundamentally changes how NFTs are filtered by chain.

3. SmokeConfirmationsRedesigned (HIGH priority) - Hero-NFT component in confirmation flows updated with better null handling and uses new selector. Tests show it's part of confirmation UX.

4. SmokeWalletPlatform (MEDIUM priority) - Network switching and multi-chain state management could be affected by these selector changes since they relate to how the selected chain is determined.

Confidence: 85% - High confidence based on:

• Clear understanding of changes through code review
• Deprecations marked explicitly in code comments
• Changes are focused on multi-chain NFT handling
• Test coverage shows impact on confirmations and assets
• Only minor uncertainty about whether network switching edge cases might be affected

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud