[Bug] [Backend] Purge Orphan KYC Documents from Cloudinary Upon Account Deletion

[Pee-pheelips]

Description

When executing a merchant deletion request in merchantDeletion.service.ts, the database records for KYC documents are deleted:

    // 3. Delete KYC documents (files already on Cloudinary — caller must purge separately)
    await tx.kYCDocument.deleteMany({ where: { kyc: { merchantId } } });

However, the caller (merchantDeletion.controller.ts) never performs the file purge. This leaves sensitive merchant PII (passport files, proof of address) orphaned on Cloudinary indefinitely.

Steps to Resolve

1. Before deleting the KYCDocument records in the database transaction, query the document URLs and public_ids.
2. In the controller or deletion service, call deleteFromCloudinary(public_id) for each file.
3. Ensure that if the Cloudinary deletion fails, it logs an alert so developers can manually reconcile or retry the deletion.

[wolfyres]

@wolfyres has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi maintainer,

I’d love to claim this issue.

I have a strong background in Web3 dev, and solid experience solving similar issue.

I can execute this task smoothly following your exact guidelines and submit a verified, reviewable PR within 10 hours.

PLEASE assign this to me!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @wolfyres to this issue.

[6akola]

@6akola has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Please, I would like to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @6akola to this issue.

[Maximum-Prosper]

@Maximum-Prosper has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hey Maintainer.
I'd like to contribute to this project.
Please kindly assign me.
Thank you.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Maximum-Prosper to this issue.