Skip to content

FlashTank is not locally balanced #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentind-met opened this issue Apr 6, 2022 · 4 comments · May be fixed by #297
Open

FlashTank is not locally balanced #113

valentind-met opened this issue Apr 6, 2022 · 4 comments · May be fixed by #297
Labels
⚖️ Local Balance Component is not locally balanced ❓ Dynamica questions Question to be asked to dynamica

Comments

@valentind-met
Copy link
Collaborator

FlashTank is not locally balanced, possibly because of outlet connectors.

@valentind-met valentind-met added 🆕 MML3 ⚖️ Local Balance Component is not locally balanced labels Apr 6, 2022
@pierre-eliep-met pierre-eliep-met added the ❓ Dynamica questions Question to be asked to dynamica label Apr 6, 2022
@AndreaBartolini
Copy link
Contributor

AndreaBartolini commented Jul 25, 2022

I see the following potential issues that require some analysis and/or model modification (if necessary) by Metroscope:

  1. the instantiated model IsoPFlowModel is balanced because the input variable W_input has been added and put in relation with the variable W by means of the equation W = W_input. This is generally correct, the point is that the input variable W_input has no binding equation in the FlashTank model that instantiates the IsoPFlowModel model, and this is not correct because only the input variables at top-level can be left without binding,

  2. probably the cause of the local unbalancing of the model is related to 1) plus the balance equation steam_phase.W + liquid_phase.W = 0 at the top-level;

@casella
Copy link
Collaborator

casella commented Sep 14, 2022

Result of today's meeting with @pepmts, @casella, and @AndreaBartolini: the current structure of the model is not adequate, because the structure of the physical system does not have two parallel branches, but rather a single control volume.

It is suggested to directly write the mass and energy balance equations for such a volume (possibly in a generic base class) and then add the two extra equations fixing the saturated liquid and vapour enthalpies at the outlet ports.

@pierre-eliep-met
Copy link
Collaborator

This discussion also made us realize that the steam dryer was not locally balanced

@pierre-eliep-met pierre-eliep-met added this to the MML3 Publication milestone Sep 22, 2022
@pierre-eliep-met pierre-eliep-met linked a pull request Oct 19, 2022 that will close this issue
12 tasks
@pierre-eliep-met
Copy link
Collaborator

@casella and @AndreaBartolini I have some difficulties in #297, the model is still not locally balanced but I don't know why, can you have a look there ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚖️ Local Balance Component is not locally balanced ❓ Dynamica questions Question to be asked to dynamica
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants