Skip to content

Commit 9123f1a

Browse files
committed
fixup! fix the FIXMEs
1 parent e3e356f commit 9123f1a

6 files changed

+6
-6
lines changed

lldb/test/Shell/Expr/TestClangModuleLoadError_InvalidSearchPath.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ expr blah
4444

4545
# CHECK: note: couldn't find module search path directory {{.*}}sources
4646
## FIXME: We never attempted to load bar.
47-
# CHECK-NOT: bar
47+
# CHECK-NOT: couldn't find module search path

lldb/test/Shell/Expr/TestClangModuleLoadError_InvalidSubmodule.test

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,4 @@ run
4848
## Make sure expression fails so the 'note' diagnostics get printed.
4949
expr blah
5050

51-
# CHECK: note: couldn't load submodule 'baz' of module 'foo' (top-level module: foo)
52-
## FIXME: We never attempted to load bar.
53-
# CHECK-NOT: bar
51+
# CHECK: note: couldn't load submodule 'baz' of module 'foo'

lldb/test/Shell/Expr/TestClangModuleLoadError_InvalidTopLevelModule.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
# RUN: -fmodule-map-file=%t/sources/module.modulemap \
99
# RUN: -fmodules-cache-path=%t/ModuleCache -o %t.out
1010
# RUN: sed -i '' -e 's/foo\.h/baz\.h/' %t/sources/module.modulemap
11+
# RUN: sed -i '' -e 's/bar\.h/qux\.h/' %t/sources/module.modulemap
1112
#
1213
# RUN: %lldb -x -o "settings set interpreter.stop-command-source-on-error false" \
1314
# RUN: -s %t/sources/commands.input %t.out -o exit 2>&1 | FileCheck %s

lldb/test/Shell/Expr/TestClangModuleLoadError_ModulemapParsing.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ expr blah
4343

4444
# CHECK: note: failed to parse and load modulemap file in {{.*}}sources
4545
## FIXME: We never attempted to load bar.
46-
# CHECK-NOT: bar
46+
# CHECK-NOT: failed to parse and load modulemap

lldb/test/Shell/Expr/TestClangModuleLoadError_NoModule.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
# RUN: -fmodule-map-file=%t/sources/module.modulemap \
1010
# RUN: -fmodules-cache-path=%t/ModuleCache -o %t.out
1111
# RUN: sed -i '' -e 's/module foo/module baz/' %t/sources/module.modulemap
12+
# RUN: sed -i '' -e 's/module bar/module qux/' %t/sources/module.modulemap
1213
#
1314
# RUN: %lldb -x -o "settings set interpreter.stop-command-source-on-error false" \
1415
# RUN: -s %t/sources/commands.input %t.out -o exit 2>&1 | FileCheck %s

lldb/test/Shell/Expr/TestClangModuleLoadError_NoModuleMap.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@ expr blah
3939

4040
# CHECK: note: couldn't find modulemap file in {{.*}}sources
4141
## FIXME: We never attempted to load bar.
42-
# CHECK-NOT: bar
42+
# CHECK-NOT: couldn't find modulemap

0 commit comments

Comments
 (0)