Skip to content

Commit b3c7037

Browse files
Mizuchifacebook-github-bot
authored andcommitted
Migrate OSS project to handle protocol split
Summary: X-link: facebook/CacheLib#386 X-link: facebook/fb303#67 fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system. Differential Revision: D74687663
1 parent 366a5b4 commit b3c7037

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

ThriftLibrary.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ macro(thrift_generate
208208
${output_path}/gen-${language}/${file_name}_constants.cpp
209209
${output_path}/gen-${language}/${file_name}_data.cpp
210210
${output_path}/gen-${language}/${file_name}_types.cpp
211+
${output_path}/gen-${language}/${file_name}_types_compact.cpp
212+
${output_path}/gen-${language}/${file_name}_types_binary.cpp
211213
)
212214
foreach(service ${services})
213215
set("${file_name}-${language}-HEADERS"

build/fbcode_builder/CMake/FBThriftCppLibrary.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE)
6969
"${output_dir}/gen-cpp2/${base}_data.h"
7070
"${output_dir}/gen-cpp2/${base}_data.cpp"
7171
"${output_dir}/gen-cpp2/${base}_types.cpp"
72+
"${output_dir}/gen-cpp2/${base}_types_compact.cpp"
73+
"${output_dir}/gen-cpp2/${base}_types_binary.cpp"
7274
"${output_dir}/gen-cpp2/${base}_metadata.cpp"
7375
)
7476
foreach(service IN LISTS ARG_SERVICES)

0 commit comments

Comments
 (0)