added xml parsing error handling, fix example

Author: MarcG-TUE

package/cmtrace/cmtrace/libtracetosvg.py

@@ -37,28 +37,13 @@ def max_firing_time(self):
         if len(l) == 0:
             return 0.0
         return max(map(lambda i: i[1], l))
-        # return reduce(f, self.firings.intervals(), (True, 0.0)
-        # first = True
-        # result = 0.0
-        # for firing in self.firing_intervals():
-        #     if first or firing[1] > result:
-        #         result = firing[1]
-        #         first = False
-        # return result
 
     def min_firing_time(self):
         """ return the smallest of starting times of all firing intervals or zero if the list is empty"""
         l = self.firing_intervals()
         if len(l) == 0:
             return 0.0
         return min(map(lambda i: i[0], l))
-        # first = True
-        # result = 0.0
-        # for firing in self.firing_intervals():
-        #     if first or firing[0] < result:
-        #         result = firing[0]
-        #         first = False
-        # return result
 
 
 def read_trace_xml(filename, scale=1.0):
@@ -74,7 +59,10 @@ def read_trace_xml(filename, scale=1.0):
         error("Trace file ({0}) does not exist.".format(filename))
 
     # parse the XML
-    root = ET.parse(filename)
+    try:
+        root = ET.parse(filename)
+    except ET.ParseError as e:
+        error("Failed to parse xml file ({0}).\nReason: {1}".format(filename, str(e)))
 
     # dictionary to collect the actor traces
     # keys will be actor scenarios plus actor names

trace.xml

@@ -1,8 +1,8 @@
 <?xml version="1.0"?>
 <trace>
     <inputs>
-        <input id="0" timestamp="0" iteration="0">
-        <input id="1" timestamp="1" iteration="0">
+        <input id="0" timestamp="0" iteration="0"/>
+        <input id="1" timestamp="1" iteration="0"/>
     </inputs>
     <firings>
         <firing id="0" start="0" end="2" actor="B" scenario="a" iteration="0"/>
@@ -19,8 +19,8 @@
         <firing id="11" start="9" end="10" actor="A" scenario="a" iteration="3"/>
     </firings>
     <outputs>
-        <output id="0" timestamp="2" iteration="0">
-        <output id="1" timestamp="5" iteration="0">
-        <output id="2" timestamp="5" iteration="0">
-    </inputs>
+        <output id="0" timestamp="2" iteration="0"/>
+        <output id="1" timestamp="5" iteration="0"/>
+        <output id="2" timestamp="5" iteration="0"/>
+    </outputs>
 </trace>