From 7141c6d5e2222b5b89c7d9acbd2523f8bd4986a7 Mon Sep 17 00:00:00 2001 From: Gorka Date: Thu, 11 Jun 2026 18:31:01 -0300 Subject: [PATCH] ci: pin deno to 2.8.2 (2.8.3 regressed import-map override resolution) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit deno 2.8.3 (which setup-deno's `v2.x` floats to) stopped applying the pay tests' import-map module overrides (config.ts→PGlite, jwt, channel deps). The real modules load instead, so src/config/env.ts eager-evaluates requireEnv("DATABASE_URL") at module load and the DB-touching pay tests fail (34 passed / 11 failed). Bisected in Linux containers, cold cache: - deno 2.8.2 / 2.7.x: overrides applied (`deno info` shows env.ts absent from the pay graph) → suite green. - deno 2.8.3: overrides bypassed (`deno info` shows the real config/jwt/ service-auth-secret + env.ts in the graph) → suite red. With env vars satisfied the failures become assertion errors (real deps, not mocks), confirming every override is inert, not just one. Pin to 2.8.2 (the last version that honors the overrides) until the upstream regression is fixed. CI-config only; no production code touched. --- .github/workflows/pr.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c32c6e7..cb27cf1 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -11,7 +11,7 @@ jobs: - uses: actions/checkout@v4 - uses: denoland/setup-deno@v2 with: - deno-version: v2.x + deno-version: 2.8.2 - run: deno fmt --check lint: @@ -20,7 +20,7 @@ jobs: - uses: actions/checkout@v4 - uses: denoland/setup-deno@v2 with: - deno-version: v2.x + deno-version: 2.8.2 - run: deno lint test: @@ -29,7 +29,7 @@ jobs: - uses: actions/checkout@v4 - uses: denoland/setup-deno@v2 with: - deno-version: v2.x + deno-version: 2.8.2 - run: deno test --allow-all --config src/http/v1/pay/tests/deno.json src/http/v1/pay/ build: