Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observations/forward_operators/obs_def_cice_mod.f90 initialize_module #842

Open
hkershaw-brown opened this issue Mar 19, 2025 · 0 comments
Labels
cice Sea Ice models

Comments

@hkershaw-brown
Copy link
Member

observations/forward_operators/obs_def_cice_mod.f90
initialize_module is taking an ensemble_handle & ens_size

subroutine initialize_module(state_handle, ens_size)

Came in this commit, so not super surprising that it got missed:
Image

Here is the model_interpolate call

if (obs_type == QTY_SEAICE_CATEGORY) then
if (cat_index <= Ncat) then
istatus = 0
expected_obs = cat_index
RETURN
endif
endif

Loop CATEGORIES : do icat =1, MAX_CATEGORIES call to model_interpolate to count up until
if (cat_index <= Ncat)

seems an overly complicated way to do it.

just return Ncat right?
Or hot take, just have cice model_mod have a get_ncat function since obs_def_cice_mod.f90 seems like it is specific to CICE anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cice Sea Ice models
Projects
None yet
Development

No branches or pull requests

1 participant