Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs_def_cice_mod.f90 get_expected_agreg_freeboard unused arguments #843

Open
hkershaw-brown opened this issue Mar 19, 2025 · 0 comments · May be fixed by #850
Open

obs_def_cice_mod.f90 get_expected_agreg_freeboard unused arguments #843

hkershaw-brown opened this issue Mar 19, 2025 · 0 comments · May be fixed by #850
Assignees
@hkershaw-brown
Labels
cice Sea Ice models

Comments

@hkershaw-brown
Copy link
Member

subroutine get_expected_agreg_freeboard has unused arguments: var_sic, var_siv, var_snv

DART/observations/forward_operators/obs_def_cice_mod.f90

Line 180 in c5600dc

subroutine get_expected_agreg_freeboard(state_handle, ens_size, location, &

The calling code is passing in QTY_SEAICE_CONCENTR, QTY_SEAICE_VOLUME, QTY_SEAICE_SNOWVOLUME

DART/observations/forward_operators/obs_def_cice_mod.f90

Lines 40 to 42 in c5600dc

! call get_expected_agreg_freeboard(state_handle, ens_size, location, &
! QTY_SEAICE_CONCENTR, QTY_SEAICE_VOLUME, QTY_SEAICE_SNOWVOLUME, &
! expected_obs, istatus)

@hkershaw-brown hkershaw-brown self-assigned this Mar 31, 2025
hkershaw-brown added a commit that referenced this issue Mar 31, 2025
@hkershaw-brown
remove unused arguments get_expected_agreg_freeboard
b0c3c67 
fixes #843
@hkershaw-brown hkershaw-brown added the cice Sea Ice models label Mar 31, 2025
@hkershaw-brown hkershaw-brown linked a pull request Mar 31, 2025 that will close this issue
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkershaw-brown hkershaw-brown

Labels
cice Sea Ice models
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Freeboard fwd operator for radar, laser, and original freeboard NCAR/DART
1 participant
@hkershaw-brown