Skip to content

Latest commit

 

History

History
242 lines (189 loc) · 10.6 KB

CONTRIBUTING.md

File metadata and controls

242 lines (189 loc) · 10.6 KB

Contribute

There are already numerous contributors to this project and we are always welcoming more!

If you are a first time contributor we recommend expressing your interest by creating an issue where you describe how you would like to contribute. We will then get in touch with you to discuss the details, e.g. by having a zoom with you.

Step by step technical contribution guide

To contribute to this project, please follow those steps:

  1. Clone this repository: git clone https://github.com/NEUBIAS/training-resources/
  2. On your computer, make a new branch. For example, if you would like to contribute python code to the binarization.md module you may: git checkout -b pythonBinarization
  3. Now add your changes on your computer (staying in this branch) - see "Adding a new module" section, below.
  4. When you are done, please git add .; git commit -m "some message"
  5. Now you can upload your branch to the online repository by typing: git push --set-upstream origin pythonBinarization.
  6. Go to the online repository on gitlab: https://git.embl.de/grp-bio-it/image-analysis-training-resources
  7. On gitlab, there will now be button at the top of the page. Click this button to stage a "merge request" of your contribution (in your branch) to the master branch. There will also a possibility to assign a project maintainer to review your contribution and to merge it. Please select someone appropriate here.
  8. Thank you for your contribution!

Editor

Visual Studio Code supports code formating and highlighting with the Liquid and Jekyll Syntax Support extensions (available via VSCode marketplace).

After the extensions are installed the document type can be changed to "Liquid" in the bottom right corner. Set document type to liquid.

This should enable syntax highlighting. By pressing Ctrl + Shift + p you can search for Liquid: Enable Formatting and Liquid: Format Document.

Adding a new module

Each module page is built from a template (_layouts/module.html), ensuring a consistent structure and style for the whole collection. To create a new module, you will need to add a few files in a few different places in this repository.

For convenience there is the add_new_module.sh shell script that will automatically create the file and folder skeleton for a new module. Example usage: ./add_new_module.sh distance_transform

Module file

Most important is the module file itself. This module file should be saved with a short, descriptive name (no spaces!) ending with the .md (Markdown) extension. The content of this Markdown file can be limited to a header, written in YAML, according to the specification below. However, you may wish to add additional page content, written in Markdown, beneath the closing --- of this header. Any content written there will appear in the rendered page after the concept map and/or figure, and before the Activity section.

YAML Header Specification

All fields not marked as optional are required for the page to build. You can check that your YAML is valid with this tool.

---
title:     Title of the Module
layout:    module               # don't change this

prerequisites:
  - "a list of things that learners should know"
  - "in order to understand this module"

objectives:
  - "a list of learning objectives"
  - "see note 1 below for more info"

motivation: |
  A description of *why* you would want to learn this.
  Can be written in
  (GitHub-flavoured) [Markdown](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet).
  Line breaks will be respected, so you can add lists etc using Markdown syntax.

concept_map: > # see note 2
  graph TD
      A[Christmas] -->|Get money| B(Go shopping)
      B --> C{Let me think}
      C -->|One| D[Laptop]
      C -->|Two| E[iPhone]
      C -->|Three| F[fa:fa-car Car];

figure: /figures/mymodule.png # store the example image for your module in the `figures` folder and provide the absolute path from the root of the site here.
figure_legend: Some description of the figure. (optional)

multiactivities: # see note 3
  - ["mymodule/mymodule_act1.md", [["ImageJ GUI", "mymodule/mymodule_act1_imagejgui.md"], ["ImageJ Macro", "mymodule/mymodule_act1_imagejmacro.ijm"], ["ImageJ Jython", "mymodule/mymodule_act1_jython.py"], ["skimage napari", "mymodule/mymodule_act1_skimage_napari.py", "python"]]]
  - ["mymodule/mymodule_act2.md", [["ImageJ GUI", "mymodule/mymodule_act2_imagejgui.md"], ["ImageJ Macro", "mymodule/mymodule_act2_imagejmacro.ijm"], ["ImageJ Jython", "mymodule/mymodule_act2_jython.py"]
  ["skimage napari", "mymodule/mymodule_act2_skimage_napari.py"]]]

assessment: |
  Language-agnostic questions to assess learner understanding of the key concept
  covered in the module.
  (optional)
learn_next: # see note 4
  - "[name_of_one](calibration)"
  - "[or_more_modules](object_splitting)"
  - "[to link to next](display)"
external_links:
  - "[link to](https://external.page.com)"
---

Notes:

  1. Learning objectives should be worded as endings to a sentence beginning "After completing this lesson, learners should be able to...". We recommend starting each learning objective with a verb from Bloom's Taxonomy
  2. Concept maps are drawn with Mermaid.js. The indentation of the chart description is important, so be careful!
  3. The multiactivities fields should be nested arrays: ["header.md", [["analysis_platform1_name", "mymodule/analysis_platform1_impl"],["analysis_platform2_name", "mymodule/analysis_platform2_impl"], ... ]]
  4. The points in "Learn Next" are Markdown links, which should be formed as [Module Title](modulefilename), where the extension has been removed from the filename.
Associated files

Below is a list of all the other files that one should provide to accompany a new module, as well as the appropriate location for each (relative to the top level of the repository). Examples are given for a /modules/mymodule.md

  • The figure image:
    • an file containing an example image to illustrate the concept being taught in the module
    • location: /figures/mymodule.png
    • if the figure is hard to make, please consider also adding a corresponding a PPTX file
    • location: /figures/resources/mymodule.pptx
  • The activities files:
    • There may be multiple activities for each module
    • Each activity needs:
      • a markdown header file that explains in general terms what the activity is about
      • location: _includes/mymodule/mymodule_myactivity.md
      • files that implement the activity header in a specific platform, e.g.
      • location: _includes/mymodule/mymodule_myactivity_imagejgui.md
      • location: _includes/mymodule/mymodule_myactivity_skimage.py

Building the website locally

It is important to test locally whether the website builds correctly before submitting changes to the repo.

Building locally OSX

To test your changes locally, install jekyll on your system. Instructions for Mac OSX are here: https://jekyllrb.com/docs/installation/macos/.

Once you have jekyll and bundler setup, clone and move into this repository, and run:

make serve

All going well, your built pages are now beng served locally. Copy the URL provided in the output (should be http://127.0.0.1:4000/image-analysis-training-resources/) and paste it into your web browser. Now you can navigate around the locally-built version of the pages and check whether you're happy to submit your changes to be merged into master 👍

Building locally Windows (without make)

You need to install several tools (ruby and then jekyll). Please follow the instructions [https://jekyllrb.com/docs/installation/windows/] follow step 1-4

All commands are run from a standard/gitbash terminal.

  • Install ruby using the [https://rubyinstaller.org/] (tested with devkit rubyinstaller-devkit-3.0.3-1-x64 used default suggested path etc. MSYS2 and MINGW development toolchain)
  • Install jekyll
gem install jekyll bundler
  • Check your jekyll install
jekyll -v
  • Try to compile the page
bundle exec jekyll serve
  • It will probably complain about missing gems. Install those, e.g.
gem install github-pages
gem install webrick
  • Run again
bundle exec jekyll serve
  • If everything works fine you will get something like
 bundle exec jekyll serve
Configuration file: D:/Code/training-resources/_config.yml
            Source: D:/Code/training-resources
       Destination: D:/Code/training-resources/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 5.007 seconds.
  Please add the following to your Gemfile to avoid polling for changes:
    gem 'wdm', '>= 0.1.0' if Gem.win_platform?
 Auto-regeneration: enabled for 'D:/Code/training-resources'
    Server address: http://127.0.0.1:4000
  Server running... press ctrl-c to stop.
  • Copy the URL provided in the output, should be http://127.0.0.1:4000/image-analysis-training-resources/) and paste it into your web browser. Now you can navigate around the locally-built version of the pages and check whether you're happy to submit your changes to be merged into master 👍

Caveat: Some users must run their gem install commands as administrator. We do not know exactly why, but it may depend on their respective Windows installation.

See your new module

To see a module edit the file _config.yml and add your module (the file name in _modules with .md) to the list and the appropriate location

module_order:
- pixels
- spatial_calibration
- lut
- binarization
- connected_components
- datatypes
- measure_shapes
- workflow_segment_2d_nuclei_measure_shape
- measure_intensities
- global_background_correction
- filter_neighbourhood
- median_filter
- local_background_correction
- filter_objects
- workflow_segment_2d_noisy_nuclei_filter_objects_measure_shape
- MY_MODULE

Note that when jekyll is serving your page, changes on existing files are automatically updated.

Questions

If you have any questions please ask us in an issue.