Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for allom_h2cd when allom_dmode=1 #1312

Closed
glemieux opened this issue Jan 13, 2025 Discussed in #1308 · 0 comments · Fixed by #1314
Closed

Add a check for allom_h2cd when allom_dmode=1 #1312

glemieux opened this issue Jan 13, 2025 Discussed in #1308 · 0 comments · Fixed by #1314

Comments

@glemieux
Copy link
Contributor

Discussed in #1308

Originally posted by glemieux January 10, 2025
Reviewing the CrownDepth subroutine and the default parameter file, I'm assuming that the allom_h2cd1 value should be between 0 and 1 such that the crown depth can't exceed the cohort height. I don't see a check in PRTCheckParams however.

@glemieux glemieux linked a pull request Jan 21, 2025 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from ❕Todo to ✔ Done in FATES issue board Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant