Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in calculating carbon flux due to fire mortality #1365

Open
XiulinGao opened this issue Mar 20, 2025 · 1 comment · May be fixed by #1368
Open

Error in calculating carbon flux due to fire mortality #1365

XiulinGao opened this issue Mar 20, 2025 · 1 comment · May be fixed by #1368
Assignees
Labels
science: fire science: mortality Pertaining to changes to plant mortality

Comments

@XiulinGao
Copy link
Contributor

I was going through code related to fire mortality and found this. I'm not sure if there's a reason we don't want to include carbon flux from understaory or it's just a bug. Let me know if you want me to fix this by adding carbon flux from understory too.

hio_firemortality_carbonflux_si_pft(io_si,ft) = sites(s)%fmort_carbonflux_canopy(ft) / g_per_kg

@glemieux glemieux added science: mortality Pertaining to changes to plant mortality science: fire labels Mar 24, 2025
@ckoven
Copy link
Contributor

ckoven commented Mar 24, 2025

Thanks @XiulinGao for spotting. I agree, we should add sites(s)%fmort_carbonflux_understory(ft) as well. Could you open a PR with that fix?

@XiulinGao XiulinGao linked a pull request Mar 26, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
science: fire science: mortality Pertaining to changes to plant mortality
Projects
Status: ❕Todo
Development

Successfully merging a pull request may close this issue.

3 participants