Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues handling Inf likelihoods #94

Open
dfalster opened this issue Mar 18, 2016 · 0 comments
Open

Issues handling Inf likelihoods #94

dfalster opened this issue Mar 18, 2016 · 0 comments

Comments

@dfalster
Copy link
Contributor

The refactor of the stateline code is great! However, it seems a bug may have crept in in the handling of Inf likelihoods. Our model has a strong boundary for plausible parameters, beyond which the nll returned is Inf. In the older stateline, the algorithm would detect the Inf and search around to find a reasonable starting position. In the refactored code, we never seem to find the plausible region.

It turns out this is not a problem with algorithm so much as detecting an Inf correctly. @lmccalman suggested instead of returning Inf we return a very big number (e.g. max float). Indeed, when I do this stateline works as expected, i.e. finds plausible regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant