Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the option to export the nFONLL theories explicitly to be used by other programs. #218

Open
scarlehoff opened this issue Feb 26, 2025 · 10 comments
Assignees
Labels
refactor Refactor code

Comments

@scarlehoff
Copy link
Member

Clearly the nFONLL theories are confusing due to quite a few things.

  1. There is no meaning in the names, and going from 00 to 06 it just makes it more confusing since our theories are always integer
  2. If the theories go to the theories repository, they get confused with another thousand theories.

I think one possible solution is adding a fonll_theory_cards config option where the fonll cards are output. These cards can then be used by pinefarm, they don't need to be committed anywhere (grids that usde these cards will have the cards burned in by pinefarm) and are isolated. This solves both 1 and 2.

personally I would, on top of that, change the 00 to 06 to something like m0n1 to represent the different steps in massive/massless and flavour number.

To keep backwards compatibility if the option doesn't exist, just output it to the theories like now.

Let's discuss this here instead of NNPDF/nnpdf#2285

@giacomomagni
Copy link
Contributor

giacomomagni commented Feb 26, 2025

I agree to change the names to something more meaningful.
On the other side I found really confusing copying and duplicating theory cards. In my experience, it's less error prone if you place (or source) the theories in a single folder (and eventually pineko provide an command (or a flag) to remove the nFONLL ones once the FKtables are combined ? )

@scarlehoff
Copy link
Member Author

scarlehoff commented Feb 26, 2025

The problem is that often you end up running pineko and pinefarm in different computers, so you end up copying them around.

Maybe a good intermediate solution is to provide a pineko fonll export_tcards <theory> <output_folder, default '.'> so only when you want to run the grids (that doesn't happen often) you actually see the runcards?

edit: now that I've written it down I like this idea a lot because that makes it explicit that these theories are to be used by something else that it is not pineko... what do you think?

@RoyStegeman
Copy link
Member

There is no meaning in the names, and going from 00 to 06 it just makes it more confusing since our theories are always integer

This was done because theoryIDs are (were?) expected to be ints at some point in the entire pipeline.

@scarlehoff
Copy link
Member Author

I think still are, this would need to be changed in a few places but I think the change it is worth it.

@RoyStegeman
Copy link
Member

The problem is that often you end up running pineko and pinefarm in different computers, so you end up copying them around.

I don't, so maybe that's why I don't really think this is such an issue

Maybe a good intermediate solution is to provide a pineko fonll export_tcards <theory> <output_folder, default '.'>

Sure, you can save them in a separate folder. Personally I would probably not use this becuase it requires me to change the submission script depending on wether I'm running DIS grids/fktables or something else, but if that's easier for you I don't have a problem

@scarlehoff
Copy link
Member Author

I don't

Stoomboot gave some of you too much unchecked power 😆

Personally I would probably not use this becuase it requires me to change the submission script depending on wether I'm running DIS grids/fktables or something else,

But this is already the case? DIS and hadronic run differently.

In any case, the export command you only need it if you need to run in different folders. If you are doing everything in the same place then that's fine, no need to export anything anywhere.

@RoyStegeman
Copy link
Member

Stoomboot gave some of you too much unchecked power 😆

At this point my laptop is merely an interface to stoomboot

But this is already the case? DIS and hadronic run differently.

Sure, the difference is the theoryID so in my submission I loop over a combination of (dataset, theoryid). I don't think having nfonll separated is worth also having to keep track of the paths.

@scarlehoff scarlehoff changed the title Output the nFONLL theories to some specific folder Give the option to export the nFONLL theories explicitly to be used by other programs. Feb 26, 2025
@felixhekhorn
Copy link
Contributor

I'm not a big fan of the 00 either (also because it is not transparent - the order is random), but it is convenient ... if we open a new directory this will end up into almost two identical pinefarm.toml ...

@scarlehoff
Copy link
Member Author

I think pinefarm doesn't know about integers and while pineko does, it is the only code who uses the fonll cards so I think I should be able to do both the export and the name change without much problem.

I won't do the extra folder as that one has been clearly botched by the community 😅

@RoyStegeman
Copy link
Member

I won't do the extra folder as that one has been clearly botched by the community 😅

If it's useful for you, feel free to implement it. As long as the default option is just the theory cards path from the pineko.toml it won't change anything for those who don't want to separate nfonll cards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

No branches or pull requests

4 participants