Running pineko yields ModuleNotFoundError: No module named 'nnpdf_data.commondataparser

[achiefa]

When I run pineko with nnpdf=true in the pineko.toml, I get this error

  File "/opt/homebrew/Caskroom/miniconda/base/envs/nnpdf_doc/lib/python3.12/site-packages/pineko/cli/theory_.py", line 34, in opcards
    theory.TheoryBuilder(theory_id, datasets, overwrite=overwrite).opcards()
  File "/opt/homebrew/Caskroom/miniconda/base/envs/nnpdf_doc/lib/python3.12/site-packages/pineko/theory.py", line 284, in opcards
    self.iterate(self.opcard, tcard=tcard)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/nnpdf_doc/lib/python3.12/site-packages/pineko/theory.py", line 250, in iterate
    grids = self.load_grids(ds)
            ^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/nnpdf_doc/lib/python3.12/site-packages/pineko/theory.py", line 150, in load_grids
    raw_grids = read_grids_from_nnpdf(ds, configs.configs)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/nnpdf_doc/lib/python3.12/site-packages/pineko/utils.py", line 33, in read_grids_from_nnpdf
    from nnpdf_data.commondataparser import EXT, parse_new_metadata
ModuleNotFoundError: No module named 'nnpdf_data.commondataparser'

Now, it seems to me that nnpdf_data does not contain any module called commondataparser. The only commondataparser that I can see is in validphys. Does pineko need to be updated?

https://github.com/NNPDF/pineko/blob/ffc0c9409353e29147d8305b78df93644122d383/src/pineko/utils.py#L33C5-L33C68

CC @scarlehoff @felixhekhorn

[scarlehoff]

No, you need to install nnpdf-data instead of nnpdf. But I'm going to tag today the code with both together so that you can install either (at the moment nnpdf-data is a separate PR)