Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity credit decreases when AEP is increased which may not be expected #406

Open
johnjasa opened this issue Nov 15, 2024 · 0 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@johnjasa
Copy link
Collaborator

johnjasa commented Nov 15, 2024

In a recent PR (#405) the capcred changed in an unexpected way. Cursory investigations to the cause were not fruitful. It's unclear what the cause is but we should determine if this is expected or unexpected behavior.

@kbrunik said:
This is where the capacity credit percent is calculated, it looks to me that it should increase given increased AEP, so it does seem strange.

def calc_capacity_credit_percent(self, interconnect_kw: float) -> float:

@jaredthomas68 followed up:
Thanks for that. I wonder if the problem is in changes made to the interconnect_kw for dispatching. I have not investigated, just throwing that out for now.

@johnjasa johnjasa changed the title This is where the capacity credit percent is calculated, it looks to me that it should increase given increased AEP, so it does seem strange. https://github.com/NREL/HOPP/blob/53490cb54abfe024e6338310a88374707d54ed20/hopp/simulation/technologies/power_source.py#L210 Capacity credit decreases when AEP is increased which may not be expected Nov 15, 2024
@johnjasa johnjasa added bug Something isn't working help wanted Extra attention is needed labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant