Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plotting dependency #493

Open
ppinchuk opened this issue Dec 7, 2024 · 1 comment
Open

Update plotting dependency #493

ppinchuk opened this issue Dec 7, 2024 · 1 comment
Assignees
@ppinchuk
Labels
dependencies Issues/pull requests related to a dependency p-low Priority: low
Milestone
Update dependencies

Comments

@ppinchuk
Copy link
Collaborator

ppinchuk commented Dec 7, 2024

IIRC, matplotlib is a required dependency of reV, but is only used in a few hidden bespoke utility functions. We should either migrate those functions (e.g. to a bespoke plotting notebook), or make matplotlib an optional dependency
@ppinchuk ppinchuk added this to the Update dependencies milestone Dec 7, 2024
@ppinchuk ppinchuk self-assigned this Dec 7, 2024
@ppinchuk ppinchuk added dependencies Issues/pull requests related to a dependency p-low Priority: low and removed feature labels Feb 10, 2025
@ppinchuk
Copy link
Collaborator Author

ppinchuk commented Apr 5, 2025

Took a step towards this in #528.
I don't actually think we can fully drop the matplotlib dependency since it is used in the QA/QC module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppinchuk ppinchuk

Labels
dependencies Issues/pull requests related to a dependency p-low Priority: low
Projects
None yet
Milestone
Update dependencies
Development

No branches or pull requests
1 participant
@ppinchuk