Fix port conflict when deploying multiple IOCs in a single run

set_fact has higher precedence than include_vars in Ansible, so the
include_vars reset of deploy_ioc_nextport at the start of each loop
iteration was silently ignored after the first iteration's set_fact.
This caused all IOCs after the first to reuse the same port number.

The same precedence issue affects deploy_ioc_executable,
deploy_ioc_template_root_path, and deploy_ioc_dbpf_list, which could
carry over between IOCs in a multi-IOC deployment.

Fix by:
- Loading defaults into a namespaced dict and resetting all affected
  per-IOC variables via set_fact each iteration, sourced from that
  dict so there is a single source of truth for default values.
- Changing the port comparison from > to >= to handle the edge case
  where max port equals the default.
- Removing deploy_ioc_loop_index from the port calculation, since
  the deployment is sequential and each iteration's config file is
  visible to the next via the find command. The index was causing
  ports to skip ahead unnecessarily.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: sligara7

roles/deploy_ioc/tasks/set-facts.yml

@@ -4,6 +4,18 @@
   ansible.builtin.include_vars:
     file: defaults/main.yml
 
+- name: Load defaults into namespace for per-IOC reset
+  ansible.builtin.include_vars:
+    file: defaults/main.yml
+    name: _deploy_ioc_defaults
+
+- name: Reset per-IOC variables that may persist via set_fact from prior iterations
+  ansible.builtin.set_fact:
+    deploy_ioc_nextport: "{{ _deploy_ioc_defaults.deploy_ioc_nextport }}"
+    deploy_ioc_executable: "{{ _deploy_ioc_defaults.deploy_ioc_executable }}"
+    deploy_ioc_template_root_path: "{{ _deploy_ioc_defaults.deploy_ioc_template_root_path }}"
+    deploy_ioc_dbpf_list: "{{ _deploy_ioc_defaults.deploy_ioc_dbpf_list }}"
+
 - name: Make sure IOC with given name is configured on host
   ansible.builtin.fail:
     msg: "IOC with name {{ deploy_ioc_ioc_name }} is not configured on host"

roles/deploy_ioc/tasks/update-config.yml

@@ -35,10 +35,10 @@
     - name: Set next port number
       ansible.builtin.set_fact:
         deploy_ioc_nextport:
-          "{{ deploy_ioc_current_max_port.stdout | int + deploy_ioc_loop_index + 1 }}" # yamllint disable-line rule:line-length
+          "{{ deploy_ioc_current_max_port.stdout | int + 1 }}"
       when:
         deploy_ioc_current_max_port.stdout != "" and
-        (deploy_ioc_current_max_port.stdout | int) > (deploy_ioc_nextport | int)
+        (deploy_ioc_current_max_port.stdout | int) >= (deploy_ioc_nextport | int)
 
 - name: Print next port number
   ansible.builtin.debug: