Skip to content

Revert no-op BENCHMARK.md change, trigger real nvskills-ci via SKILL.md - #80

Merged
ramakrishnap-nv merged 3 commits into
mainfrom
chore/revert-benchmark-blank-line
Sep 15, 2026
Merged

ramakrishnap-nv merged 3 commits into
mainfrom
chore/revert-benchmark-blank-line

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

#79 landed a no-op change to BENCHMARK.md only, intended to trigger /nvskills-ci regeneration, and was merged before confirming the result. Per thread follow-up: BENCHMARK.md is a generated artifact excluded from NVSkills CI's change detection, so validation/signing was skipped entirely even though the pipeline reported success.

This PR:

  1. Reverts the no-op blank line in BENCHMARK.md from chore(skills): trigger benchmark regeneration for portfolio-optimization #79.
  2. Adds a small change to SKILL.md (non-generated) instead, and re-triggers /nvskills-ci so change detection actually picks it up this time.

No content/behavior change to the skill itself.

🤖 Generated with Claude Code

…ptimization"

#79 merged before confirming the NVSkills CI run actually regenerates
and commits an updated BENCHMARK.md back to the branch — it doesn't;
it only reports a pass/fail status on the existing content. Reverting
the no-op blank line since it landed on main without the intended
content update, and re-triggering /nvskills-ci from a fresh PR instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner September 14, 2026 17:41
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

BENCHMARK.md is treated as a generated artifact and excluded from
NVSkills CI's change detection, so the earlier BENCHMARK.md-only
commit caused validation/signing to be skipped even though the
pipeline reported success. Touch SKILL.md (non-generated) instead so
change detection actually picks this up.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@ramakrishnap-nv ramakrishnap-nv changed the title Revert no-op blank line in portfolio-optimization BENCHMARK.md Revert no-op BENCHMARK.md change, trigger real nvskills-ci via SKILL.md Sep 14, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nv merged commit 093a8bd into main Sep 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants