-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
ObliqueSGD.step has a pre-existing bug where the momentum buffer is computed into a local variable (buf = torch.add(...)) but never written back to state["momentum_buffer"], making momentum accumulation a no-op.
Surfaced during v0.2 clean up. Don't know if anyone need this, should have it fixed (if AI is right) at some point.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working