Skip to content

AI spotted bug in ObliqueSGD.step #136

@skyw

Description

@skyw

Describe the bug

ObliqueSGD.step has a pre-existing bug where the momentum buffer is computed into a local variable (buf = torch.add(...)) but never written back to state["momentum_buffer"], making momentum accumulation a no-op.

Surfaced during v0.2 clean up. Don't know if anyone need this, should have it fixed (if AI is right) at some point.

@mkhona-nvidia

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions