-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
check_endpoint method in nemo-evaluator's utils does not allow endpoint_type="vlm". This causes the error:
check_endpoint(
File "/opt/Evaluator/packages/nemo-evaluator/src/nemo_evaluator/core/utils.py", line 348, in check_endpoint
raise ValueError(f"Invalid endpoint type: {endpoint_type}")
ValueError: Invalid endpoint type: vlmSteps/Code to reproduce bug
Can be reproduced with this evaluator snippet
from nemo_evaluator.api import check_endpoint, evaluate
from nemo_evaluator.api.api_dataclasses import (
ApiEndpoint,
ConfigParams,
EvaluationConfig,
EvaluationTarget,
)
# Configure the evaluation target
api_endpoint = ApiEndpoint(
url="http://0.0.0.0:1235/v1/chat/completions/",
type="vlm",
model_id="megatron-model",
)
eval_target = EvaluationTarget(api_endpoint=api_endpoint)
eval_params = ConfigParams(top_p=0, temperature=0, limit_samples=2, parallelism=1)
eval_config = EvaluationConfig(type="ocrbench", params=eval_params, output_dir="results")
if __name__ == "__main__":
check_endpoint(
endpoint_url=eval_target.api_endpoint.url,
endpoint_type=eval_target.api_endpoint.type,
model_name=eval_target.api_endpoint.model_id,
)
evaluate(target_cfg=eval_target, eval_cfg=eval_config) Expected behavior
Support for endpoint_type "vlm" needs to be added to check_endpoint utility to avoid error when evaluating on vlm benchmarks.
Additional context
Add any other context about the problem here.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working