fix: remove unexpected side effect in get_srun_flags (#408)

Currently, if `nemo_run_dir` is falsy, this function will append mounts to the object mounts list, resulting in unexpected extension of the list with every call.

This function is called by materialize, which it turns out is even called by the `__repr__` and as such one would expect it not to have any side effects.

Signed-off-by: Jakub Bliźniuk <opliko@opliko.dev>

Author: oplik0

nemo_run/run/ray/slurm.py

@@ -203,15 +203,13 @@ def get_srun_flags(mounts: list[str], container_image: Optional[str]) -> str:
             if gres_specification:
                 _srun_flags.append(gres_specification)
 
+            new_mounts = copy.deepcopy(mounts)
             if self.nemo_run_dir:
-                new_mounts = copy.deepcopy(mounts)
                 for i, mount in enumerate(new_mounts):
                     if mount.startswith(RUNDIR_SPECIAL_NAME):
                         new_mounts[i] = mount.replace(RUNDIR_SPECIAL_NAME, self.nemo_run_dir, 1)
 
                 new_mounts.append(f"{self.nemo_run_dir}:/{RUNDIR_NAME}")
-            else:
-                new_mounts = mounts
 
             new_mounts.append(f"{self.cluster_dir}:{self.cluster_dir}")
             new_mounts.append(f"{logs_dir}:{logs_dir}")