fix(ci): Brev E2E suite silently skips — brev login removed in #1470

[cjagwani]

Problem

The Brev E2E suite silently skips all tests (reports 1 skipped, 0 passed) because the Brev CLI is not authenticated on the GH Actions runner.

Root cause: Commit 374a847 (refactor(installer): unify host preflight and thin deploy compatibility, PR #1470) removed the brev("login", "--token", process.env.BREV_API_TOKEN) call from brev-e2e.test.js and replaced it with a brev("ls") pre-check (hasAuthenticatedBrev). But nothing authenticates the CLI first — the Brev CLI v0.6.322 does not read BREV_API_TOKEN from the environment; it requires ~/.brev/credentials.json.

Before #1470

const REQUIRED_VARS = ["BREV_API_TOKEN", "NVIDIA_API_KEY", "GITHUB_TOKEN", "INSTANCE_NAME"];
// ...
brev("login", "--token", process.env.BREV_API_TOKEN);  // ← wrote credentials

After #1470

const REQUIRED_VARS = ["NVIDIA_API_KEY", "GITHUB_TOKEN", "INSTANCE_NAME"];  // ← BREV_API_TOKEN removed
const hasAuthenticatedBrev = (() => {
  try { brev("ls"); return true; } catch { return false; }  // ← fails, no credentials file
})();
describe.runIf(hasRequiredVars && hasAuthenticatedBrev)("Brev E2E", () => {  // ← skips

Evidence

• Last working run (Apr 4): https://github.com/NVIDIA/NemoClaw/actions/runs/23968693963 — 988s, 1 passed
• First broken run (Apr 8): https://github.com/NVIDIA/NemoClaw/actions/runs/24160260650 — 16s, 1 skipped
• Multiple retries with fresh tokens: all skip identically

Fix

Write ~/.brev/credentials.json in the "Install Brev CLI" workflow step before vitest runs.

[wscurran]

✨ Thanks for reporting this issue, which identifies a bug with the Brev E2E suite skipping tests and may be related to the removal of the Brev login call in a previous PR.

---

Possibly related open PRs:

• #1470 refactor(installer): unify host preflight and thin deploy compatibility