chore(ci): label non-maintainer issues for triage (#1120)

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

Author: johntmyers

.github/workflows/issue-triage.yml

@@ -8,17 +8,18 @@ permissions:
   issues: write
 
 jobs:
-  label-maintainer-issues:
+  label-non-maintainer-issues:
     runs-on: ubuntu-latest
     if: github.repository_owner == 'NVIDIA'
     steps:
-      - name: Check maintainer permissions
-        id: maintainer
+      - name: Check contributor permissions
+        id: contributor
         uses: actions/github-script@v7
         with:
           result-encoding: string
           script: |
             const author = context.payload.issue.user.login;
+            const maintainerPermissions = ['admin', 'maintain', 'write'];
 
             try {
               const { data } = await github.rest.repos.getCollaboratorPermissionLevel({
@@ -27,25 +28,24 @@ jobs:
                 username: author,
               });
 
-              if (['admin', 'maintain', 'write'].includes(data.permission)) {
+              if (maintainerPermissions.includes(data.permission)) {
                 console.log(`${author} has maintainer permissions: ${data.permission}.`);
-                return 'true';
+                return 'false';
               }
 
-              console.log(`${author} does not have maintainer permissions: ${data.permission}.`);
+              console.log(`${author} is not a maintainer; permission is ${data.permission}.`);
+              return 'true';
             } catch (e) {
               if (e.status === 404) {
-                console.log(`${author} is not a repository collaborator.`);
-                return 'false';
+                console.log(`${author} is not a repository collaborator; labeling for triage.`);
+                return 'true';
               }
 
               throw e;
             }
 
-            return 'false';
-
       - name: Add triage label
-        if: steps.maintainer.outputs.result == 'true'
+        if: steps.contributor.outputs.result == 'true'
         uses: actions/github-script@v7
         with:
           script: |
@@ -55,41 +55,3 @@ jobs:
               issue_number: context.issue.number,
               labels: ['state:triage-needed'],
             });
-
-  check-agent-diagnostic:
-    runs-on: ubuntu-latest
-    # Only run on bug reports (title starts with "bug:")
-    if: startsWith(github.event.issue.title, 'bug:')
-    steps:
-      - name: Check for agent diagnostic section
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const body = context.payload.issue.body || '';
-
-            // Check if the Agent Diagnostic section has substantive content.
-            // GitHub issue forms render textarea labels as h3 headings, but
-            // issues created through gh or API clients often use h2 headings.
-            const diagnosticMatch = body.match(
-              /^#{2,4}\s+Agent Diagnostic[s]?\s*\n([\s\S]*?)(?=\n#{2,4}\s+|$)/im
-            );
-
-            const diagnosticText = diagnosticMatch?.[1].trim() || '';
-            const hasSubstantiveDiagnostic = diagnosticText.length > 0
-              && !diagnosticText.toLowerCase().startsWith('example:')
-              && !['n/a', 'none', 'no', 'not applicable'].includes(diagnosticText.toLowerCase());
-
-            if (hasSubstantiveDiagnostic) {
-              console.log('Agent diagnostic section found with content. Passing.');
-              return;
-            }
-
-            console.log('Agent diagnostic section missing or placeholder. Flagging.');
-
-            // Add state:triage-needed label
-            await github.rest.issues.addLabels({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.issue.number,
-              labels: ['state:triage-needed']
-            });

CONTRIBUTING.md

@@ -92,7 +92,7 @@ Skills connect into pipelines. Individual skill files don't describe these relat
 - **Policy iteration:** `openshell-cli` → `generate-sandbox-policy`
 
 Workflow state labels use the `state:*` prefix, and security work uses `topic:security`. GitHub issue templates assign built-in issue types where applicable, and agent-created issues should use issue types or manual follow-up rather than type labels.
-New issues opened by repository collaborators with `write`, `maintain`, or `admin` permission are automatically labeled `state:triage-needed` by the issue triage workflow.
+New issues opened by users without `write`, `maintain`, or `admin` repository permission are automatically labeled `state:triage-needed` by the issue triage workflow.
 
 ## Prerequisites