Skip to content

Commit 6207c4f

Browse files
committed
revert: remove portable GB300 packaging
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
1 parent 7f47df4 commit 6207c4f

5 files changed

Lines changed: 6 additions & 236 deletions

File tree

crates/openshell-driver-mxc/qualification/README.md

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -84,33 +84,3 @@ and OpenClaw bundles, `evidence.json`, and the final validation log. Do not put
8484
provider credentials in command lines or retained files. Optional credential
8585
coverage must use a scoped non-production credential and prove that retained
8686
artifacts contain no secret value.
87-
88-
## Build a portable collector
89-
90-
Build one hash-manifested ZIP from a clean qualification revision:
91-
92-
```powershell
93-
powershell -NoProfile -ExecutionPolicy Bypass `
94-
-File crates/openshell-driver-mxc/qualification/package-gb300-woa.ps1
95-
```
96-
97-
The archive contains `Run-Qualification.ps1`, the contract, validator, concise
98-
instructions, and a manifest that identifies and hashes the collector. Keep the
99-
extracted directory outside the checkout. Point it at the clean OpenShell branch
100-
being tested without copying qualification files into that branch:
101-
102-
```powershell
103-
$env:OPENSHELL_GB300_REPO_ROOT = 'C:\path\to\OpenShell'
104-
$env:OPENSHELL_GB300_BASE_SHA = '<full reviewed origin/windows SHA>'
105-
$env:OPENSHELL_GB300_HARDWARE_ATTESTATION = 'GB300'
106-
$env:OPENSHELL_WXC_EXEC_PATH = 'C:\mxc-kit\bin\wxc-exec.exe'
107-
$env:OPENSHELL_GB300_NODE_PATH = 'C:\path\to\arm64\node.exe'
108-
$env:OPENSHELL_GB300_OPENCLAW_DIR = 'C:\path\to\node_modules\openclaw'
109-
$env:OPENSHELL_GB300_EVIDENCE_DIR = 'D:\evidence\openshell-gb300-<run-id>'
110-
111-
powershell -NoProfile -ExecutionPolicy Bypass -File .\Run-Qualification.ps1
112-
```
113-
114-
The target checkout does not need to contain this qualification directory, but
115-
it must have canonical `origin`, descend directly from the reviewed `windows`
116-
SHA, and be clean. Share the ZIP's SHA256 out of band with the tester.

crates/openshell-driver-mxc/qualification/package-gb300-woa.ps1

Lines changed: 0 additions & 151 deletions
This file was deleted.

crates/openshell-driver-mxc/qualification/run-gb300-woa.ps1

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
[CmdletBinding()]
88
param(
9-
[string] $RepoRoot = $env:OPENSHELL_GB300_REPO_ROOT,
109
[string] $ExpectedBaseSha = $env:OPENSHELL_GB300_BASE_SHA,
1110
[string] $WxcExecPath = $env:OPENSHELL_WXC_EXEC_PATH,
1211
[string] $NodeExePath = $env:OPENSHELL_GB300_NODE_PATH,
@@ -20,10 +19,7 @@ Set-StrictMode -Version Latest
2019
$ErrorActionPreference = "Stop"
2120
$PSNativeCommandUseErrorActionPreference = $false
2221

23-
if ([string]::IsNullOrWhiteSpace($RepoRoot)) {
24-
$RepoRoot = Join-Path $PSScriptRoot "..\..\.."
25-
}
26-
$RepoRoot = (Resolve-Path -LiteralPath $RepoRoot).Path
22+
$RepoRoot = (Resolve-Path (Join-Path $PSScriptRoot "..\..\..")).Path
2723
$ManifestPath = Join-Path $PSScriptRoot "gb300-woa.json"
2824
$ValidatorPath = Join-Path $PSScriptRoot "validate.py"
2925
$WindowsWrapper = Join-Path $RepoRoot "tasks\scripts\windows-msvc.ps1"
@@ -246,7 +242,7 @@ $Durations["source-provenance"] = [Math]::Round($sourceTimer.Elapsed.TotalSecond
246242

247243
$uv = Get-Command uv -ErrorAction Stop
248244
Invoke-LoggedProcess "contract-integrity" "contract-validation.log" $uv.Source @(
249-
"run", "python", $ValidatorPath, "--repo-root", $RepoRoot, "contract"
245+
"run", "python", $ValidatorPath, "contract"
250246
)
251247

252248
$probePath = Join-Path $ExampleSource "probe-mxc-host.ps1"
@@ -485,8 +481,7 @@ $record = [ordered]@{
485481
}
486482
Write-Json $record $recordPath
487483
Invoke-LoggedProcess "evidence-validation" "evidence-validation.log" $uv.Source @(
488-
"run", "python", $ValidatorPath, "--repo-root", $RepoRoot,
489-
"evidence", "--record", $recordPath,
484+
"run", "python", $ValidatorPath, "evidence", "--record", $recordPath,
490485
"--artifact-root", $EvidenceDir, "--expected-base-sha", $ExpectedBaseSha
491486
)
492487

crates/openshell-driver-mxc/qualification/validate.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"crates/openshell-driver-mxc/examples/probe-mxc-host.ps1",
3838
"crates/openshell-driver-mxc/examples/run-mxc-e2e.ps1",
3939
"crates/openshell-driver-mxc/examples/run-openclaw-forward-test.ps1",
40+
"crates/openshell-driver-mxc/qualification/gb300-woa.json",
4041
"tasks/scripts/windows-msvc.ps1",
4142
"tasks/windows.toml",
4243
}
@@ -270,10 +271,9 @@ def validate_evidence(
270271
record: dict[str, Any],
271272
artifact_root: Path,
272273
expected_base_sha: str,
273-
repo_root: Path | None = None,
274274
) -> list[str]:
275275
"""Validate one retained evidence record against the static matrix."""
276-
errors = validate_contract(contract, repo_root=repo_root)
276+
errors = validate_contract(contract, repo_root=None)
277277
if not SHA_PATTERN.fullmatch(expected_base_sha):
278278
errors.append("expected base SHA must be 40 lowercase hexadecimal characters")
279279
if record.get("schema_version") != 1:
@@ -485,12 +485,6 @@ def main(argv: list[str] | None = None) -> int:
485485
default=script_dir / "gb300-woa.json",
486486
help="Path to the qualification contract",
487487
)
488-
parser.add_argument(
489-
"--repo-root",
490-
type=Path,
491-
default=repo_root,
492-
help="OpenShell checkout to validate (required for an external bundle)",
493-
)
494488
subparsers = parser.add_subparsers(dest="mode", required=True)
495489
subparsers.add_parser("contract", help="Validate the static scope contract")
496490
evidence = subparsers.add_parser(
@@ -504,15 +498,14 @@ def main(argv: list[str] | None = None) -> int:
504498
try:
505499
contract = load_json(args.manifest)
506500
if args.mode == "contract":
507-
errors = validate_contract(contract, repo_root=args.repo_root)
501+
errors = validate_contract(contract, repo_root=repo_root)
508502
else:
509503
record = load_json(args.record)
510504
errors = validate_evidence(
511505
contract,
512506
record,
513507
args.artifact_root,
514508
args.expected_base_sha,
515-
repo_root=args.repo_root,
516509
)
517510
except (OSError, ValueError, json.JSONDecodeError) as error:
518511
print(f"ERROR: {error}", file=sys.stderr)

python/gb300_mxc_qualification_test.py

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
import copy
99
import hashlib
1010
import importlib.util
11-
import subprocess
12-
import sys
1311
from pathlib import Path
1412
from typing import TYPE_CHECKING, TypedDict, cast
1513

@@ -163,41 +161,6 @@ def test_runner_hash_binds_a_versioned_openclaw_package() -> None:
163161
assert "openclaw_package_json_sha256" in source
164162

165163

166-
def test_runner_supports_an_external_qualification_bundle() -> None:
167-
source = (QUALIFICATION_DIR / "run-gb300-woa.ps1").read_text(encoding="utf-8")
168-
169-
assert "OPENSHELL_GB300_REPO_ROOT" in source
170-
assert '"--repo-root", $RepoRoot' in source
171-
172-
173-
def test_portable_bundle_does_not_require_qualification_files_in_target() -> None:
174-
assert not any(
175-
"qualification" in relative for relative in VALIDATOR.REQUIRED_REPOSITORY_PATHS
176-
)
177-
178-
179-
def test_validator_cli_honors_external_repo_root(tmp_path: Path) -> None:
180-
for relative in VALIDATOR.REQUIRED_REPOSITORY_PATHS:
181-
path = tmp_path / relative
182-
path.parent.mkdir(parents=True, exist_ok=True)
183-
path.write_text("fixture\n", encoding="utf-8")
184-
185-
result = subprocess.run(
186-
[
187-
sys.executable,
188-
str(QUALIFICATION_DIR / "validate.py"),
189-
"--repo-root",
190-
str(tmp_path),
191-
"contract",
192-
],
193-
check=False,
194-
capture_output=True,
195-
text=True,
196-
)
197-
198-
assert result.returncode == 0, result.stderr
199-
200-
201164
def test_repository_contract_is_valid() -> None:
202165
errors = VALIDATOR.validate_contract(_load_contract(), repo_root=REPO_ROOT)
203166
assert errors == []

0 commit comments

Comments
 (0)