Skip to content

Commit 044d3bc

Browse files
committed
Fix serialization utils test
Signed-off-by: Iman Tabrizian <[email protected]>
1 parent 7f44888 commit 044d3bc

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

cpp/tests/unit_tests/executor/serializeUtilsTest.cpp

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,34 +1087,38 @@ TEST(SerializeUtilsTest, RequestAndBufferInfo)
10871087
// Test with all fields populated
10881088
{
10891089
kv_cache::RequestAndBufferInfo original{"testAgent", "127.0.0.1:8080",
1090-
tensorrt_llm::batch_manager::RequestInfo{}, kv_cache::MemoryDesc{nullptr, 1024, 0},
1090+
tensorrt_llm::batch_manager::RequestInfo{},
1091+
std::vector<kv_cache::MemoryDesc>{kv_cache::MemoryDesc{nullptr, 1024, 0}},
10911092
std::make_optional<std::string>("metadata"), 1};
10921093

10931094
auto deserialized = serializeDeserializeNotification(original);
10941095

10951096
EXPECT_EQ(original.mAgentName, deserialized.mAgentName);
10961097
EXPECT_EQ(original.mAddress, deserialized.mAddress);
10971098
EXPECT_EQ(original.mRequestInfo.getRequestId(), deserialized.mRequestInfo.getRequestId());
1098-
EXPECT_EQ(original.mBufferDesc.getAddr(), deserialized.mBufferDesc.getAddr());
1099-
EXPECT_EQ(original.mBufferDesc.getLen(), deserialized.mBufferDesc.getLen());
1100-
EXPECT_EQ(original.mBufferDesc.getDeviceId(), deserialized.mBufferDesc.getDeviceId());
1099+
ASSERT_EQ(original.mBufferDescs.size(), deserialized.mBufferDescs.size());
1100+
EXPECT_EQ(original.mBufferDescs[0].getAddr(), deserialized.mBufferDescs[0].getAddr());
1101+
EXPECT_EQ(original.mBufferDescs[0].getLen(), deserialized.mBufferDescs[0].getLen());
1102+
EXPECT_EQ(original.mBufferDescs[0].getDeviceId(), deserialized.mBufferDescs[0].getDeviceId());
11011103
EXPECT_EQ(original.mMetadata, deserialized.mMetadata);
11021104
EXPECT_EQ(original.mValidConnectionIdx, deserialized.mValidConnectionIdx);
11031105
}
11041106

11051107
// Test with nullopt metadata
11061108
{
11071109
kv_cache::RequestAndBufferInfo original{"testAgent2", "192.168.1.1:9090",
1108-
tensorrt_llm::batch_manager::RequestInfo{}, kv_cache::MemoryDesc{nullptr, 512, 0}, std::nullopt, 2};
1110+
tensorrt_llm::batch_manager::RequestInfo{},
1111+
std::vector<kv_cache::MemoryDesc>{kv_cache::MemoryDesc{nullptr, 512, 0}}, std::nullopt, 2};
11091112

11101113
auto deserialized = serializeDeserializeNotification(original);
11111114

11121115
EXPECT_EQ(original.mAgentName, deserialized.mAgentName);
11131116
EXPECT_EQ(original.mAddress, deserialized.mAddress);
11141117
EXPECT_EQ(original.mRequestInfo.getRequestId(), deserialized.mRequestInfo.getRequestId());
1115-
EXPECT_EQ(original.mBufferDesc.getAddr(), deserialized.mBufferDesc.getAddr());
1116-
EXPECT_EQ(original.mBufferDesc.getLen(), deserialized.mBufferDesc.getLen());
1117-
EXPECT_EQ(original.mBufferDesc.getDeviceId(), deserialized.mBufferDesc.getDeviceId());
1118+
ASSERT_EQ(original.mBufferDescs.size(), deserialized.mBufferDescs.size());
1119+
EXPECT_EQ(original.mBufferDescs[0].getAddr(), deserialized.mBufferDescs[0].getAddr());
1120+
EXPECT_EQ(original.mBufferDescs[0].getLen(), deserialized.mBufferDescs[0].getLen());
1121+
EXPECT_EQ(original.mBufferDescs[0].getDeviceId(), deserialized.mBufferDescs[0].getDeviceId());
11181122
EXPECT_EQ(original.mMetadata, deserialized.mMetadata);
11191123
EXPECT_EQ(original.mValidConnectionIdx, deserialized.mValidConnectionIdx);
11201124
}
@@ -1194,7 +1198,8 @@ TEST(SerializeUtilsTest, NotificationInfo)
11941198
// Test with RequestAndBufferInfo variant
11951199
{
11961200
kv_cache::RequestAndBufferInfo requestInfo{"testAgent", "127.0.0.1:8080",
1197-
tensorrt_llm::batch_manager::RequestInfo{}, kv_cache::MemoryDesc{nullptr, 1024, 0},
1201+
tensorrt_llm::batch_manager::RequestInfo{},
1202+
std::vector<kv_cache::MemoryDesc>{kv_cache::MemoryDesc{nullptr, 1024, 0}},
11981203
std::make_optional<std::string>("test_metadata"), 1};
11991204

12001205
kv_cache::NotificationInfo original{requestInfo};

0 commit comments

Comments
 (0)