Skip to content

Commit 59df7d0

Browse files
committed
fix rpc proxy test
Signed-off-by: Superjomn <[email protected]>
1 parent b1aa8ff commit 59df7d0

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tensorrt_llm/executor/rpc_proxy.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def setup_engine_remote(self):
8787

8888
def shutdown_remote(self):
8989
logger_debug(f"Shutting down rpc remote", color="yellow")
90-
self.rpc_client.shutdown().remote()
90+
self.rpc_client.shutdown().remote(need_response=False)
9191

9292
def abort_request(self, request_id: int) -> None:
9393
return self.rpc_client.abort_request(request_id).remote()
@@ -117,7 +117,9 @@ def shutdown(self):
117117
# (e.g., during garbage collection in that thread)
118118
if self.main_loop_thread and threading.current_thread(
119119
) != self.main_loop_thread:
120-
self.main_loop_thread.join()
120+
self.main_loop_thread.join(timeout=2.0)
121+
if self.main_loop_thread.is_alive():
122+
logger.warning("Main loop thread did not exit gracefully")
121123

122124
# 3. shutdown the mpi session, this should wait until all the PyExecutor
123125
# processes are shutdown

0 commit comments

Comments
 (0)