Repository navigation
Conversation
Vendor validation:
|
|
/bot run --disable-fail-fast |
Vendor validation:
|
|
PR_Github #81677 [ run ] triggered by Bot. Commit: |
|
PR_Github #81677 [ run ] completed with state |
Vendor validation:
|
Vendor validation:
|
Vendor validation:
|
3a707c9 to
f7367f7
Compare
…source Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
f7367f7 to
4cf4e67
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #83770 [ run ] triggered by Bot. Commit: |
|
PR_Github #83770 [ run ] completed with state
|
@coderabbitai summary
Description
Extract general PrimTS compilation, caching, and paged-context fixes from the persistent compatibility patch into the locked FlashInfer source. On current main, this reduces the patch from 883 to 377 lines (506 fewer lines).
Upstream implementation: flashinfer-ai/flashinfer#8005
The source branch
yuxianq/flashinfer:prims-ts-upstream-refactor--backportis rebased onto the new canonical branchtrtllm-prims-ts-dev-20261107at911d6a9d62308b6c8a5249e8dc4aabc7518020f1. The lock pins the rebased source commit52be15bbc078ad86710fa2a92367c80bcead3a76. The consumer PR is rebased onto TensorRT-LLM main at00b59a491841aa72b5d704d2b5f709f13a846277.The source owns precompile/probe modes, placeholder-safe compiler memos, validated/device-specific sparse plan caching, prepared sparse MLA launches, and import-order-safe paged helpers. Conflict resolution preserves the new dev branch's public APIs, planned host/tensor scale ABI, and SM107 dispatch. Geometry cache keys include the effective compile target; tensor-scale launches keep the full path. The positional output-quantization ABI fix is already in the new base.
The regenerated compatibility patch preserves main's metadata-extension, reduction, and Rubin compatibility adaptations. The metadata and parallel-reduction compatibility files remain byte-identical to main. The lock, patch, and digests were generated with
scripts/vendor/manage.py.Keep the PR as a draft while upstream #8005 is reviewed. Promotion should advance the new canonical branch after upstream merge.
Test Coverage
Validated after the 2026-11-10 rebase:
trtllm-prims-ts-dev-20261107tip.git range-diffaudits completed for both branches. The consumer changed-file set remains the same nine files; intentional differences adapt to the new scale APIs and SM107 target selection. No follow-up repair commit was needed.scripts/vendor/manage.py check flashinfer-prims-ts --repo <source-worktree>: PASS-OFFLINE and PASS-LOCAL. All vendor entries pass offline checks.tests/unittest/others/test_vendor_sources.py: 72 passed.git diff --check, source mypy/Ruff, and applicable pre-commit checks in both repositories pass.Test consolidation: the source branch's added suite collects 13 cases instead of 14 (CPU 9 → 8; GPU unchanged at 5). Removed the redundant normal-order import subprocess, covered by existing paged-context testing; retained the reverse-order cycle regression. The four dtype × pool combinations select distinct JIT paths, and the fifth GPU case checks cold persistence/reload. No runtime speedup is inferred from case count. This consumer PR adds no CI test entries.
Full model/executor integration tests were not run locally. CI is retriggered with the previous command,
/bot run --disable-fail-fast.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.