You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[https://nvbugs/6930053][test] Cherry-pick #20384 from release/1.3: Remove test_starlette_constraint_floor - #21948
Forward-port of release/1.3 PR #20384 (Emma Qiao) to main. It deletes tests/unittest/others/test_web_dependency_security.py, matching release/1.3.
Adapted to main: tests/integration/test_lists/waives.txt also drops its entry for test_web_framework_security_floors (https://nvbugs/6930053), because that test is deleted with the file.
Notes for reviewers:
On release/1.3, constraints.txt no longer carries the starlette workaround. On main, constraints.txt still has starlette>=1.3.1 (GHSA-82w8-qh3p-5jfq). After this PR, main keeps that pin, and the starlette>=1.3.1 floor in requirements.txt, but no unit test checks either of them.
The deleted file also contains test_web_framework_security_floors (the fastapi, prometheus_fastapi_instrumentator and starlette floors in requirements.txt). That test was already waived on main.
Test Coverage
Test-only removal; no new code paths.
No other test list or file references test_web_dependency_security.py on main.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
This change removes the web dependency security-floor tests and their waiver. It does not change application code or dependency manifests. No other references to the removed test or test ID were found in the searched test directories. The removal also removes automated checks for the FastAPI, prometheus_fastapi_instrumentator, and Starlette version constraints.
QA Engineer Review
The change deletes tests/unittest/others/test_web_dependency_security.py, including test_web_framework_security_floors and test_starlette_constraint_floor. It also removes the test_web_framework_security_floors waiver from tests/integration/test_lists/waives.txt. The removed tests checked dependency version floors and exclusions in requirements.txt and constraints.txt. No replacement coverage is shown. Coverage verdict: needs follow-up.
Per-File QA Perspective
tests/unittest/others/test_web_dependency_security.py — Deleted tests checked web dependency security version constraints. The file was not listed in the changed test-list entries; CI or manual-QA listing status is not available.
tests/integration/test_lists/waives.txt — Removes the waiver for test_web_framework_security_floors. This changes waiver tracking; it does not add or modify test coverage.
…tarlette_constraint_floor
Forward-port of release/1.3 PR NVIDIA#20384
(release/1.3 commit 7c2f938) to main.
Adapted to main: also drop the waives.txt entry for
test_web_framework_security_floors, which is deleted with the file.
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
This is a test-only removal with no production behavior change. No actionable merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description check
The description explains why the test file and waiver entry are removed, notes the Starlette pins that will remain unchecked, and describes test coverage. It includes the required sections and checkli…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title identifies removal of the Starlette constraint-floor test, which is part of the change, but it does not cover the broader deletion of web dependency security tests.
Full details: Description check
Explanation
The description explains why the test file and waiver entry are removed, notes the Starlette pins that will remain unchecked, and describes test coverage. It includes the required sections and checklist.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
SimengLiu-nv
changed the title
[None][test] Cherry-pick #20384 from release/1.3: Remove test_starlette_constraint_floor
[https://nvbugs/6930053][test] Cherry-pick #20384 from release/1.3: Remove test_starlette_constraint_floor
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward-port of release/1.3 PR #20384 (Emma Qiao) to main. It deletes
tests/unittest/others/test_web_dependency_security.py, matching release/1.3.Adapted to main:
tests/integration/test_lists/waives.txtalso drops its entry fortest_web_framework_security_floors(https://nvbugs/6930053), because that test is deleted with the file.Notes for reviewers:
constraints.txtno longer carries the starlette workaround. On main,constraints.txtstill hasstarlette>=1.3.1(GHSA-82w8-qh3p-5jfq). After this PR, main keeps that pin, and thestarlette>=1.3.1floor inrequirements.txt, but no unit test checks either of them.test_web_framework_security_floors(the fastapi, prometheus_fastapi_instrumentator and starlette floors inrequirements.txt). That test was already waived on main.Test Coverage
test_web_dependency_security.pyon main.PR Checklist
Please review the following before submitting your PR:
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.🤖 Generated with Claude Code
Dev Engineer Review
This change removes the web dependency security-floor tests and their waiver. It does not change application code or dependency manifests. No other references to the removed test or test ID were found in the searched test directories. The removal also removes automated checks for the FastAPI,
prometheus_fastapi_instrumentator, and Starlette version constraints.QA Engineer Review
The change deletes
tests/unittest/others/test_web_dependency_security.py, includingtest_web_framework_security_floorsandtest_starlette_constraint_floor. It also removes thetest_web_framework_security_floorswaiver fromtests/integration/test_lists/waives.txt. The removed tests checked dependency version floors and exclusions inrequirements.txtandconstraints.txt. No replacement coverage is shown. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/unittest/others/test_web_dependency_security.py— Deleted tests checked web dependency security version constraints. The file was not listed in the changed test-list entries; CI or manual-QA listing status is not available.tests/integration/test_lists/waives.txt— Removes the waiver fortest_web_framework_security_floors. This changes waiver tracking; it does not add or modify test coverage.