Skip to content

Fix the onnx checker to use model path when model size > 2gib #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

Fix the onnx checker to use model path when model size > 2gib #502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95345f4
Fix the onnx checker to use model path when model size > 2gib
hthadicherla Nov 4, 2025
8521626
Merge branch 'main' into hthadicherla/fix_model_check
hthadicherla Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modelopt/onnx/trt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,13 @@ def load_onnx_model(
intermediate_generated_files.append(ir_version_onnx_path)

# Check that the model is valid
onnx.checker.check_model(onnx_model)
if use_external_data_format:
# For large models, use the file path to avoid protobuf size limitation
model_path_to_check = ir_version_onnx_path or static_shaped_onnx_path or onnx_path
onnx.checker.check_model(model_path_to_check)
else:
# For smaller models, checking the model object is fine
onnx.checker.check_model(onnx_model)

return (
onnx_model,
Expand Down